Bug 155753 - Web Inspector: Consider Automation script names as internal and hide them
Summary: Web Inspector: Consider Automation script names as internal and hide them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-22 10:16 PDT by Timothy Hatcher
Modified: 2016-03-22 14:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2016-03-22 10:20 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (6.20 KB, patch)
2016-03-22 10:29 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-03-22 10:16:59 PDT 
They have a "__Web" prefix and a "__" suffix.
Comment 1 Radar WebKit Bug Importer 2016-03-22 10:17:33 PDT 
<rdar://problem/25293310>
Comment 2 Timothy Hatcher 2016-03-22 10:20:10 PDT 
Created attachment 274660 [details]
Patch
Comment 3 Timothy Hatcher 2016-03-22 10:20:34 PDT 
Comment on attachment 274660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274660&action=review

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1189
>  function isWebInspectorDebugScript(url)

I suppose I could change the function name too.
Comment 4 Timothy Hatcher 2016-03-22 10:29:03 PDT 
Created attachment 274661 [details]
Patch
Comment 5 Joseph Pecoraro 2016-03-22 13:53:44 PDT 
Comment on attachment 274661 [details]
Patch

Nice! r=me
Comment 6 WebKit Commit Bot 2016-03-22 14:44:21 PDT 
Comment on attachment 274661 [details]
Patch

Clearing flags on attachment: 274661

Committed r198555: <http://trac.webkit.org/changeset/198555>
Comment 7 WebKit Commit Bot 2016-03-22 14:44:26 PDT 
All reviewed patches have been landed.  Closing bug.