Bug 155730 - putByIndexBeyondVectorLengthWithoutAttributes should not crash if it can't ensureLength
Summary: putByIndexBeyondVectorLengthWithoutAttributes should not crash if it can't en...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-21 13:03 PDT by Keith Miller
Modified: 2016-03-25 11:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.52 KB, patch)
2016-03-24 14:45 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-03-21 13:03:16 PDT
putByIndexBeyondVectorLength should not crash if it cannot increase the size of its butterfly
Comment 1 Keith Miller 2016-03-24 14:45:35 PDT
Created attachment 274856 [details]
Patch
Comment 2 Saam Barati 2016-03-24 15:31:39 PDT
Comment on attachment 274856 [details]
Patch

can you add a test?
Comment 3 Keith Miller 2016-03-25 10:16:13 PDT
> can you add a test?

I don't have a test this is just a fix to what I suspect is the cause of on of our top crashers. We hit the RELEASE_ASSERT in putByIndexBeyondVectorLengthWithoutAttributes. The only way I see to hit that assert is to fail on the reallocation of the butterfly.
Comment 4 Keith Miller 2016-03-25 10:16:46 PDT
<rdar://problem/22570509>
Comment 5 WebKit Commit Bot 2016-03-25 11:07:38 PDT
Comment on attachment 274856 [details]
Patch

Clearing flags on attachment: 274856

Committed r198676: <http://trac.webkit.org/changeset/198676>
Comment 6 WebKit Commit Bot 2016-03-25 11:07:42 PDT
All reviewed patches have been landed.  Closing bug.