Bug 155698 - Fixed compilation with GCC 4.8.
Summary: Fixed compilation with GCC 4.8.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2016-03-20 10:05 PDT by Konstantin Tokarev
Modified: 2016-03-21 10:17 PDT (History)
7 users (show)

See Also:

Patch (1.46 KB, patch)
2016-03-20 10:08 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2016-03-21 06:21 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-03-20 10:05:17 PDT
GCC 4.8 does not allow aggregate initialization for type with deleted constructor, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52707.
Comment 1 Konstantin Tokarev 2016-03-20 10:08:30 PDT
Created attachment 274541 [details]
Comment 2 Alexey Proskuryakov 2016-03-20 22:34:26 PDT
Comment on attachment 274541 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=274541&action=review

> Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:59
> +    ImpureDataSlot(HeapLocation _key, LazyNode _value, unsigned _hash)
> +        : key(_key), value(_value), hash(_hash)

There is no need to add leading underscores here. The following is valid C++ that implements the same behavior:

    ImpureDataSlot(HeapLocation key, LazyNode value, unsigned hash)
        : key(key), value(value), hash(hash)
Comment 3 Konstantin Tokarev 2016-03-21 06:21:27 PDT
Created attachment 274583 [details]
Comment 4 WebKit Commit Bot 2016-03-21 10:17:32 PDT
Comment on attachment 274583 [details]

Clearing flags on attachment: 274583

Committed r198490: <http://trac.webkit.org/changeset/198490>
Comment 5 WebKit Commit Bot 2016-03-21 10:17:36 PDT
All reviewed patches have been landed.  Closing bug.