Bug 155686 - ShadowChicken should integrate with DFG's existing debug data about inlined tail calls
Summary: ShadowChicken should integrate with DFG's existing debug data about inlined t...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 155684
  Show dependency treegraph
 
Reported: 2016-03-19 14:57 PDT by Filip Pizlo
Modified: 2016-03-19 14:58 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-03-19 14:57:29 PDT
Currently ShadowChicken will give you confusing information when there was inlining.  That's easy to fix.  ShadowChicken doesn't need to log anything about tail calls.  We can just use the DFG's existing InlineCallFrame meta-data to fill in the missing frames.

To do this well, we need to refactor StackVisitor.  There shouldn't be a thing called StackVisitor.  There should be a functor on CallFrame, and a full-fledged object like AbstractFrame.  AbstractFrame contains all of the data about a logical stack frame, i.e. either an inline frame or machine frame.  Then, ShadowChicken::Frame can just be replaced with AbstractFrame, and the CallFrame iteration functor would use it, too.