Add mocha unit tests for measurement-set.js and measurement-adapter.js as these two files are responsible for fetching and formatting data on v3 UI and new syncing / regression detection scripts to be (re)written.
Created attachment 274486 [details] Adds tests and refactors code
Thanks for the review!
Committed r198462: <http://trac.webkit.org/changeset/198462>
Oops, my patch didn't have actual tests :(
Created attachment 274491 [details] Add tests for real
Comment on attachment 274491 [details] Add tests for real View in context: https://bugs.webkit.org/attachment.cgi?id=274491&action=review rs=me. Feel free to ask someone more familiar with measurement-set.js and measurement-adapter.js for a more through review. > Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js:1 > +'use strict'; This file alternates between using single quoted string literals and double quoted string literals. We should pick one style and stick with it for consistency. > Websites/perf.webkit.org/unit-tests/measurement-set-tests.js:1 > +'use strict'; This file alternates between using single quoted string literals and double quoted string literals. We should pick one style and stick with it for consistency.
Will fix. Thanks!
Committed r198463: <http://trac.webkit.org/changeset/198463>