Bug 155661 - Give NSURLSessionConfiguration information about parent process
Summary: Give NSURLSessionConfiguration information about parent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-18 13:47 PDT by Alex Christensen
Modified: 2016-03-19 12:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.78 KB, patch)
2016-03-18 15:27 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.79 KB, patch)
2016-03-18 15:49 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (504.21 KB, application/zip)
2016-03-18 16:26 PDT, Build Bot 		no flags Details
Patch (12.52 KB, patch)
2016-03-18 16:58 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-03-18 13:47:57 PDT 
Give NSURLSessionConfiguration information about parent process
Comment 1 Alex Christensen 2016-03-18 15:27:17 PDT 
Created attachment 274459 [details]
Patch
Comment 2 Alex Christensen 2016-03-18 15:49:40 PDT 
Created attachment 274463 [details]
Patch
Comment 3 Alex Christensen 2016-03-18 15:50:52 PDT 
Second patch rebased to apply to trunk and made it so we get the audit token on mac just like we do on ios.
Comment 4 Build Bot 2016-03-18 16:26:46 PDT 
Comment on attachment 274463 [details]
Patch

Attachment 274463 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1001862

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-03-18 16:26:49 PDT 
Created attachment 274474 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Alex Christensen 2016-03-18 16:58:03 PDT 
Created attachment 274478 [details]
Patch
Comment 7 Alex Christensen 2016-03-18 16:58:53 PDT 
Mac doesn't like the audit token.  Landing without changing Mac behavior.
Comment 8 Alex Christensen 2016-03-18 17:05:32 PDT 
http://trac.webkit.org/changeset/198457
Comment 9 Joseph Pecoraro 2016-03-18 17:13:34 PDT 
Comment on attachment 274478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274478&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:381
> +#if USE(NETWORK_SESSION)
> +    NetworkSession::setSourceApplicationAuditTokenData(sourceApplicationAuditData());
> +#endif

Can the ENABLE(REMOTE_INSPECTOR) code right about this also use sourceApplicationAuditData()?
Comment 10 Alex Christensen 2016-03-18 19:19:14 PDT 
It could on iOS, but on mac we need to return nullptr or it causes problems, but your code needs the actual audit token on mac. We could use the same code on iOS, though, to avoid asking the ui process twice on startup on iOS.
Comment 11 Alexey Proskuryakov 2016-03-19 12:00:10 PDT 
I wonder if this "audit token data" contains process bundle ID that we could use when initializing the sandbox.