Bug 155654 - ES6 spec requires that RegExpPrototype not be a RegExp object.
Summary: ES6 spec requires that RegExpPrototype not be a RegExp object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-18 11:13 PDT by Mark Lam
Modified: 2016-03-18 16:15 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (30.78 KB, patch)
2016-03-18 11:28 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch: rebased to ToT. (30.75 KB, patch)
2016-03-18 11:31 PDT, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-03-18 11:13:54 PDT 
The ES6 spec states that RegExp.prototype should not be an instance of RegExp: https://tc39.github.io/ecma262/#sec-properties-of-the-regexp-prototype-object

"The RegExp prototype object is an ordinary object. It is not a RegExp instance and does not have a [[RegExpMatcher]] internal slot or any of the other internal slots of RegExp instance objects."
Comment 1 Radar WebKit Bug Importer 2016-03-18 11:14:51 PDT 
<rdar://problem/25243459>
Comment 2 Mark Lam 2016-03-18 11:28:23 PDT 
Created attachment 274436 [details]
proposed patch.
Comment 3 Mark Lam 2016-03-18 11:31:49 PDT 
Created attachment 274437 [details]
proposed patch: rebased to ToT.
Comment 4 Mark Lam 2016-03-18 13:27:09 PDT 
This patch has passed the JSC and layout tests.  The reason the EWS bots are failing to apply the patch is because the CR characters in the ietestcenter tests are making the patcher barf.

The patch is ready for a review.
Comment 5 Mark Lam 2016-03-18 16:15:21 PDT 
Thanks for the review.  Landed in r198447: <http://trac.webkit.org/r198447>.