Bug 15564 – HitTesting is incorrect for test-anchor: middle

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Adam Rofer]

When text-anchor="middle" occurs, this causes the glyphs to not be rendered that occur before the path (which is correct behavior). When this happens, however, the entire X and Y domain less than the fallen-off text is treated (with onMouseOver) as if the text were covering the entire area.

This is not the case in other SVG viewers.

[Eric Seidel (no email)]

We'll need to build a DRT compatible test, but the attached reduction is great, thanks!

[Nikolas Zimmermann]

Hi Adam,

thanks a lot for the nice report. I'm aware of the bug, it's especially nicely visible in Web Inspector (the <textPath> x/y origin starts at 0x0, when text-anchor is not "start".

The reduction looks excellent, I'm going to make a DRT compatible layout test out of it!

Greetings,
Niko

[Nikolas Zimmermann]

Created attachment 17503 [details]
Initial patch

Bug fixed, contains a DRT compatible reduction of Adams nice testcase!

[Nikolas Zimmermann]

Created attachment 17504 [details]
DRT reduction

[Adam Roben (:aroben)]

Comment on attachment 17503 [details]
Initial patch

+                    it++;

We normally use the prefix increment operator on iterators, for efficiency.

+    if (pathData)
+        return pathData->hidden;
+
+    return false;

This can just be

return pathData && pathData->hidden;

Make sure you land the layout test and results with it.

r=me

[Nikolas Zimmermann]

Landed in r28015.
Incorported all of Adams comments.