Bug 155634 - http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky
Summary: http/tests/security/shape-image-cors-redirect-error-message-logging-*.html te...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-18 03:10 PDT by youenn fablet
Modified: 2018-04-10 16:06 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.22 KB, patch)
2018-04-10 15:00 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-03-18 03:10:55 PDT
http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are logging error messages in case of CORS checks.
They are flaky as the error message can be repeated a number of time (1 or 2) that varies according test runs
Comment 1 Radar WebKit Bug Importer 2018-04-10 14:14:51 PDT
<rdar://problem/39326489>
Comment 2 Keith Rollin 2018-04-10 14:18:43 PDT
It looks like dbates@webkit.org may have address this issue in <https://trac.webkit.org/changeset/217069/webkit>.
Comment 3 Keith Rollin 2018-04-10 15:00:43 PDT
Created attachment 337641 [details]
Patch
Comment 4 youenn fablet 2018-04-10 15:39:30 PDT
Comment on attachment 337641 [details]
Patch

Not sure there is a need for a r+ but anyway, here it is.

View in context: https://bugs.webkit.org/attachment.cgi?id=337641&action=review

> LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:1
> +CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.

Isn't this new message harder to understand by not providing the URL being loaded?
Comment 5 WebKit Commit Bot 2018-04-10 16:06:11 PDT
Comment on attachment 337641 [details]
Patch

Clearing flags on attachment: 337641

Committed r230499: <https://trac.webkit.org/changeset/230499>
Comment 6 WebKit Commit Bot 2018-04-10 16:06:12 PDT
All reviewed patches have been landed.  Closing bug.