RESOLVED FIXED 155634
http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky 
https://bugs.webkit.org/show_bug.cgi?id=155634
Summary http/tests/security/shape-image-cors-redirect-error-message-logging-*.html te...
youenn fablet
Reported 2016-03-18 03:10:55 PDT
http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are logging error messages in case of CORS checks. They are flaky as the error message can be repeated a number of time (1 or 2) that varies according test runs
Attachments
Patch (6.22 KB, patch)
2018-04-10 15:00 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-04-10 14:14:51 PDT
<rdar://problem/39326489>
Keith Rollin
Comment 2 2018-04-10 14:18:43 PDT
It looks like dbates@webkit.org may have address this issue in <https://trac.webkit.org/changeset/217069/webkit>.
Keith Rollin
Comment 3 2018-04-10 15:00:43 PDT
Created attachment 337641 [details] Patch
youenn fablet
Comment 4 2018-04-10 15:39:30 PDT
Comment on attachment 337641 [details] Patch Not sure there is a need for a r+ but anyway, here it is. View in context: https://bugs.webkit.org/attachment.cgi?id=337641&action=review > LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:1 > +CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. Isn't this new message harder to understand by not providing the URL being loaded?
WebKit Commit Bot
Comment 5 2018-04-10 16:06:11 PDT
Comment on attachment 337641 [details] Patch Clearing flags on attachment: 337641 Committed r230499: <https://trac.webkit.org/changeset/230499>
WebKit Commit Bot
Comment 6 2018-04-10 16:06:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.