Bug 155630 - [OS X] Scrollbars are sometimes erroneously reported as overlay
Summary: [OS X] Scrollbars are sometimes erroneously reported as overlay
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-18 01:09 PDT by Myles C. Maxfield
Modified: 2016-03-18 14:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2016-03-18 01:30 PDT, Myles C. Maxfield 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-03-18 01:09:52 PDT 
Scrollbars are sometimes erroneously reported as overlay
Comment 1 Myles C. Maxfield 2016-03-18 01:30:09 PDT 
Created attachment 274393 [details]
Patch
Comment 2 Darin Adler 2016-03-18 08:54:59 PDT 
Comment on attachment 274393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274393&action=review

> Source/WebCore/ChangeLog:26
> +        An alternative similar approach would be for ScrollbarThemeMac to listen to the
> +        NSPreferredScrollerStyleDidChangeNotification.

Why didn’t you chose that approach?

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:635
> +    if (auto* macTheme = macScrollbarTheme())
> +        macTheme->usesOverlayScrollbarsChanged();

I’d just call the super-local variable "theme".
Comment 3 Darin Adler 2016-03-18 08:55:09 PDT 
No regression test?
Comment 4 Myles C. Maxfield 2016-03-18 14:14:45 PDT 
Committed r198444: <http://trac.webkit.org/changeset/198444>