Bug 155622 - Add a setting to let the client toggle support for network cache speculative validation
Summary: Add a setting to let the client toggle support for network cache speculative ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-17 20:31 PDT by Chris Dumez
Modified: 2016-03-22 12:22 PDT (History)
8 users (show)

See Also:

Attachments
WIP patch (5.30 KB, patch)
2016-03-18 14:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.14 KB, patch)
2016-03-18 16:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.32 KB, patch)
2016-03-18 16:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.83 KB, patch)
2016-03-20 10:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-03-17 20:31:02 PDT 
Add a setting to let the client toggle support for network cache speculative validation.
Comment 1 Chris Dumez 2016-03-17 20:32:56 PDT 
Planning to have the setting off by default.
Comment 2 Radar WebKit Bug Importer 2016-03-17 20:33:27 PDT 
<rdar://problem/25233209>
Comment 3 Radar WebKit Bug Importer 2016-03-17 20:33:28 PDT 
<rdar://problem/25233210>
Comment 4 Anders Carlsson 2016-03-18 10:17:10 PDT 
Make sure this is not implemented as a WKPreference in the modern API.
Comment 5 Chris Dumez 2016-03-18 14:52:22 PDT 
Created attachment 274455 [details]
WIP patch
Comment 6 Chris Dumez 2016-03-18 16:04:41 PDT 
Created attachment 274467 [details]
Patch
Comment 7 Alex Christensen 2016-03-18 16:39:01 PDT 
Comment on attachment 274467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274467&action=review

> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251
> +    parameters.shouldEnableNetworkCacheSpeculativeRevalidation = m_configuration->diskCacheSpeculativeValidationEnabled() && [defaults boolForKey:WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey];

Don't we want to get rid of the WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey, too?
Comment 8 Anders Carlsson 2016-03-18 16:40:02 PDT 
Comment on attachment 274467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274467&action=review

>> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251
>> +    parameters.shouldEnableNetworkCacheSpeculativeRevalidation = m_configuration->diskCacheSpeculativeValidationEnabled() && [defaults boolForKey:WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey];
> 
> Don't we want to get rid of the WebKitNetworkCacheSpeculativeRevalidationEnabledDefaultsKey, too?

Yeah, we don't want a defaults key in WebKit.
Comment 9 Chris Dumez 2016-03-18 16:47:45 PDT 
Created attachment 274477 [details]
Patch
Comment 10 WebKit Commit Bot 2016-03-19 11:46:54 PDT 
Comment on attachment 274477 [details]
Patch

Clearing flags on attachment: 274477

Committed r198470: <http://trac.webkit.org/changeset/198470>
Comment 11 WebKit Commit Bot 2016-03-19 11:47:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Chris Dumez 2016-03-20 10:45:23 PDT 
Reopening for a follow-up as I found a bug.
Comment 13 Chris Dumez 2016-03-20 10:47:28 PDT 
Created attachment 274544 [details]
Patch
Comment 14 Chris Dumez 2016-03-22 09:23:42 PDT 
ping review?
Comment 15 WebKit Commit Bot 2016-03-22 12:21:56 PDT 
Comment on attachment 274544 [details]
Patch

Clearing flags on attachment: 274544

Committed r198544: <http://trac.webkit.org/changeset/198544>
Comment 16 WebKit Commit Bot 2016-03-22 12:22:03 PDT 
All reviewed patches have been landed.  Closing bug.