Bug 155620 - Speculative revalidation requests do not have their HTTP user-agent set
Summary: Speculative revalidation requests do not have their HTTP user-agent set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-17 20:05 PDT by Chris Dumez
Modified: 2016-03-18 16:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (15.30 KB, patch)
2016-03-18 12:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-03-17 20:05:45 PDT 
Speculative revalidation requests do not have their HTTP user-agent set.
Comment 1 Chris Dumez 2016-03-17 20:06:03 PDT 
rdar://problem/24657567
Comment 2 Chris Dumez 2016-03-17 20:14:07 PDT 
We can probably save the original request's user-agent header in the cache and then re-use that one for speculative validation. We may also need to make sure the user-agent header used by the speculative validation matches the effective user-agent of the actual request from WebCore.
Comment 3 Chris Dumez 2016-03-18 12:07:25 PDT 
Created attachment 274443 [details]
Patch
Comment 4 WebKit Commit Bot 2016-03-18 16:23:13 PDT 
Comment on attachment 274443 [details]
Patch

Clearing flags on attachment: 274443

Committed r198450: <http://trac.webkit.org/changeset/198450>
Comment 5 WebKit Commit Bot 2016-03-18 16:23:19 PDT 
All reviewed patches have been landed.  Closing bug.