Bug 155612 - SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response
Summary: SpeculativeLoad needs to continue NetworkLoad when it receives a redirect res...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 17:18 PDT by Alex Christensen
Modified: 2016-03-18 10:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2016-03-17 19:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2016-03-17 20:30 PDT, Alex Christensen 		aestes: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-03-17 17:18:26 PDT 
SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response
Comment 1 Alex Christensen 2016-03-17 19:54:31 PDT 
Created attachment 274361 [details]
Patch
Comment 2 Chris Dumez 2016-03-17 19:59:35 PDT 
Comment on attachment 274361 [details]
Patch

lgtm. Antti, can you please use your new WK2 owner powers?
Comment 3 Sam Weinig 2016-03-17 20:11:09 PDT 
Comment on attachment 274361 [details]
Patch

What is the testing strategy for this?
Comment 4 Chris Dumez 2016-03-17 20:26:06 PDT 
(In reply to comment #3)
> Comment on attachment 274361 [details]
> Patch
> 
> What is the testing strategy for this?

Layout testing speculative loading is currently not easy but I filed:
https://bugs.webkit.org/show_bug.cgi?id=155254

and am planning to work on adding test support very soon.
Comment 5 Chris Dumez 2016-03-17 20:26:33 PDT 
Comment on attachment 274361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274361&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:69
> +    m_networkLoad->continueWillSendRequest(newRequest);

this does not even build :D
Comment 6 Alex Christensen 2016-03-17 20:30:52 PDT 
Created attachment 274363 [details]
Patch
Comment 7 Alex Christensen 2016-03-17 23:13:06 PDT 
http://trac.webkit.org/changeset/198378
Comment 8 Alex Christensen 2016-03-18 10:53:48 PDT 
rdar://problem/24843454