Bug 155599 - Media elements allowed to play without a user gesture, but requiring fullscreen playback, should not be allowed to autoplay.
Summary: Media elements allowed to play without a user gesture, but requiring fullscre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 155819
Blocks:
  Show dependency tree / graph
 
Reported: 2016-03-17 14:44 PDT by Jer Noble
Modified: 2016-03-23 17:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2016-03-17 14:47 PDT, Jer Noble 		darin: review+
Details | Formatted Diff | Diff
Patch for landing (3.51 KB, patch)
2016-03-18 11:15 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-03-17 14:44:36 PDT 
Media elements allowed to play without a user gesture, but requiring fullscreen playback, should not be allowed to autoplay.
Comment 1 Jer Noble 2016-03-17 14:47:52 PDT 
Created attachment 274325 [details]
Patch
Comment 2 Darin Adler 2016-03-17 23:52:58 PDT 
Comment on attachment 274325 [details]
Patch

It’s unlikely this will all work well long term if we have no regression tests. Please figure out a way to write a regression test for this.
Comment 3 Jer Noble 2016-03-18 11:03:18 PDT 
(In reply to comment #2)
> Comment on attachment 274325 [details]
> Patch
> 
> It’s unlikely this will all work well long term if we have no regression
> tests. Please figure out a way to write a regression test for this.

Sure thing. I think it should be pretty easy, actually, to test this in LayoutTests.
Comment 4 Jer Noble 2016-03-18 11:15:48 PDT 
Created attachment 274434 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-03-22 11:04:02 PDT 
Comment on attachment 274434 [details]
Patch for landing

Clearing flags on attachment: 274434

Committed r198538: <http://trac.webkit.org/changeset/198538>
Comment 6 Alexey Proskuryakov 2016-03-23 17:09:50 PDT 
This broke two tests on iOS Simulator: https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/4266/steps/run-api-tests/logs/stdio

Will roll out, as discussed in person.
Comment 7 WebKit Commit Bot 2016-03-23 17:10:44 PDT 
Re-opened since this is blocked by bug 155819
Comment 8 Alexey Proskuryakov 2016-03-23 17:21:48 PDT 
Jer followed up explaining that a patch has already been posted elsewhere. I haven't seen it.
Comment 9 Jer Noble 2016-03-23 17:25:48 PDT 
Alexey, you sent me a link to the bug on IRC.
Comment 11 Jer Noble 2016-03-23 17:43:43 PDT 
Committed r198609: <http://trac.webkit.org/changeset/198609>