Bug 155597 - Web Inspector: Shallow size is misleading, prefer retained size in Heap Snapshot data grids
Summary: Web Inspector: Shallow size is misleading, prefer retained size in Heap Snaps...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-17 14:09 PDT by Joseph Pecoraro
Modified: 2016-03-17 16:25 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (12.62 KB, patch)
2016-03-17 15:24 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Example 1 (325.75 KB, image/png)
2016-03-17 15:28 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] Example 2 (257.37 KB, image/png)
2016-03-17 15:28 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-17 14:09:58 PDT 
* SUMMARY
Prefer retained size to the shallow size in Heap Snapshot data grids.

• The self size of an instance is its own size.
• The retained size of an instance is all of the memory that is retained by the object.
  - if the object were deleted, this would be the entire amount of memory freed
  - this includes:
    - size size
    - any dependent objects, owned exclusively by this instance

Currently the data grid shows all Arrays as having the same, 16 byte self size. That isn't very useful as some Arrays exclusively hold onto other objects and thus should be treated as larger. Retained size is exactly the value we want here.
Comment 1 Radar WebKit Bug Importer 2016-03-17 14:11:46 PDT 
<rdar://problem/25225087>
Comment 2 Joseph Pecoraro 2016-03-17 15:24:08 PDT 
Created attachment 274327 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-03-17 15:28:00 PDT 
Created attachment 274329 [details]
[IMAGE] Example 1
Comment 4 Joseph Pecoraro 2016-03-17 15:28:10 PDT 
Created attachment 274330 [details]
[IMAGE] Example 2
Comment 5 WebKit Commit Bot 2016-03-17 16:25:45 PDT 
Comment on attachment 274327 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 274327

Committed r198358: <http://trac.webkit.org/changeset/198358>
Comment 6 WebKit Commit Bot 2016-03-17 16:25:50 PDT 
All reviewed patches have been landed.  Closing bug.