Bug 155593 - [ES6] Getters and Setters should be prefixed appropriately
Summary: [ES6] Getters and Setters should be prefixed appropriately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-17 11:52 PDT by Michael Saboff
Modified: 2016-03-17 13:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (13.00 KB, patch)
2016-03-17 12:06 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2016-03-17 11:52:44 PDT
According to the ES6 spec, the names of getters and setters should have a "get " or "set ".  This is true for the getters and setter defined in our static tables.  Those that are created explicitly are currently don't have the prefixes.
Comment 1 Radar WebKit Bug Importer 2016-03-17 11:53:52 PDT
<rdar://problem/25221898>
Comment 2 Michael Saboff 2016-03-17 12:06:52 PDT
Created attachment 274309 [details]
Patch
Comment 3 Mark Lam 2016-03-17 12:15:50 PDT
Comment on attachment 274309 [details]
Patch

r=me
Comment 4 Keith Miller 2016-03-17 12:18:18 PDT
Comment on attachment 274309 [details]
Patch

LGTM, JSObject::putDirectNativeIntrinsicGetter should only be used internally so adding the "get " should not be a problem.
Comment 5 WebKit Commit Bot 2016-03-17 13:13:23 PDT
Comment on attachment 274309 [details]
Patch

Clearing flags on attachment: 274309

Committed r198348: <http://trac.webkit.org/changeset/198348>
Comment 6 WebKit Commit Bot 2016-03-17 13:13:26 PDT
All reviewed patches have been landed.  Closing bug.