Bug 155581 – Move IndexedDB regular test to web-platform-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

Following on bug 148713 discussion, it might be good to move regular IndexedDB tests to web-platform-tests folder.
That will allow updating these tests according W3C WPT repo.

[youenn fablet]

Created attachment 274274 [details]
Patch

[Darin Adler]

Comment on attachment 274274 [details]
Patch

Seems fine.

[Alexey Proskuryakov]

>  Modified also IndexedDB-private-browsing/support.js to always activate testRunner private browsing mode.

I still think that it would be cleaner to enable private browsing in .html. It was extremely surprising to me to find that hidden in support.js.

At the very least, support.js should be renamed to indicate that it's different from support.js - simply having it in a different directory is too subtle.

[youenn fablet]

(In reply to comment #3)
> >  Modified also IndexedDB-private-browsing/support.js to always activate testRunner private browsing mode.
> 
> I still think that it would be cleaner to enable private browsing in .html.
> It was extremely surprising to me to find that hidden in support.js.
> 
> At the very least, support.js should be renamed to indicate that it's
> different from support.js - simply having it in a different directory is too
> subtle.

If we add a script dedicated to those tests, the script should probably do it that way.

In the meantime, I prefer keeping all html files exactly the same as their WPT version.

Once this patch is landed, I plan to update the WPT IndexedDB tests and those tests according W3C WPT repo. Not touching the html files will make this resyncing much easier.

[WebKit Commit Bot]

Comment on attachment 274274 [details]
Patch

Clearing flags on attachment: 274274

Committed r198394: <http://trac.webkit.org/changeset/198394>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.