Bug 155575 - [ES6] Make GetProperty(.) inside ArrayPrototype.cpp spec compatible.
Summary: [ES6] Make GetProperty(.) inside ArrayPrototype.cpp spec compatible.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-16 19:24 PDT by Saam Barati
Modified: 2016-03-17 16:55 PDT (History)
10 users (show)

See Also:

Attachments
WIP (4.22 KB, patch)
2016-03-16 19:25 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (10.15 KB, patch)
2016-03-17 15:42 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
perf is neutral (65.84 KB, text/plain)
2016-03-17 16:50 PDT, Saam Barati 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-03-16 19:24:15 PDT 
...
Comment 1 Saam Barati 2016-03-16 19:25:01 PDT 
Created attachment 274254 [details]
WIP

I want to run perf numbers.
Comment 2 Saam Barati 2016-03-17 15:42:32 PDT 
Created attachment 274333 [details]
patch
Comment 3 Mark Lam 2016-03-17 15:51:43 PDT 
Comment on attachment 274333 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274333&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        operation. Instead, they need to be performed as two distince operations

typos: /distince/distinct/.

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:152
> +    // We want perform get and has in the same operation.

typo: /want perform/want to perform/.

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:154
> +    // only time it is observable is when we encounter a ProxyObject

Did you mean "when we didn't encounter"?
Comment 4 Saam Barati 2016-03-17 16:50:33 PDT 
Created attachment 274340 [details]
perf is neutral
Comment 5 Saam Barati 2016-03-17 16:55:49 PDT 
http://trac.webkit.org/changeset/198360