Bug 155574 - [iOS] Allow clients to hide the accessory view on a form input session
Summary: [iOS] Allow clients to hide the accessory view on a form input session
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-16 18:55 PDT by Chelsea Pugh
Modified: 2016-04-21 11:10 PDT (History)
5 users (show)

See Also:

Attachments
patch v1 (2.90 KB, patch)
2016-03-16 19:03 PDT, Chelsea Pugh 		mitz: review+
Details | Formatted Diff | Diff
patch v2 with name change (3.09 KB, patch)
2016-04-20 18:54 PDT, Chelsea Pugh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chelsea Pugh 2016-03-16 18:55:57 PDT 
Allow clients to hide the accessory view on a form input session. Patch forthcoming.
Comment 1 Chelsea Pugh 2016-03-16 19:03:54 PDT 
Created attachment 274253 [details]
patch v1
Comment 2 mitz 2016-03-16 22:18:28 PDT 
Comment on attachment 274253 [details]
patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=274253&action=review

r=me

I am not setting cq+, in case you are inspired to change the name before committing this, but I’m fine with going with this name, and possibly changing it later.

> Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:45
> +@property (nonatomic) BOOL hidesAccessoryView WK_AVAILABLE(NA, WK_IOS_TBA);

This can be named better, but I don’t have a great suggestion. The things that I don’t like about this name are (a) an input session isn’t really a thing that hides (or shows) the accessory view (b) it’s strange to treat the accessory view as something that’s there by default and the input session can hide, but I understand how it would be misleading to name this property showsAccessoryView, because the accessory view isn’t shown for all input types.

Here’s a not-so-great suggestion:
    // Defaults to YES.
    @property BOOL accessoryViewMayShow;
Comment 3 Chelsea Pugh 2016-04-20 18:54:44 PDT 
Created attachment 276882 [details]
patch v2 with name change
Comment 4 WebKit Commit Bot 2016-04-21 11:10:15 PDT 
Comment on attachment 276882 [details]
patch v2 with name change

Clearing flags on attachment: 276882

Committed r199823: <http://trac.webkit.org/changeset/199823>
Comment 5 WebKit Commit Bot 2016-04-21 11:10:20 PDT 
All reviewed patches have been landed.  Closing bug.