Bug 155570 - Add a new benchmark test
Summary: Add a new benchmark test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-16 17:48 PDT by Jon Lee
Modified: 2016-03-16 19:49 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.15 KB, patch)
2016-03-16 17:54 PDT, Jon Lee
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2016-03-16 17:48:05 PDT
A harder version of leaves combines opacity and size.
Comment 1 Jon Lee 2016-03-16 17:54:27 PDT
Created attachment 274246 [details]
Patch
Comment 2 Said Abou-Hallawa 2016-03-16 18:13:28 PDT
Comment on attachment 274246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274246&action=review

> PerformanceTests/Animometer/tests/dom/resources/leaves.js:6
> +        stage.element.appendChild(this.element);

Utilities.createElement()?

> PerformanceTests/Animometer/tests/dom/resources/leaves.js:21
> +        this._position = new Point(Stage.random(-this.size.width, this.maxPosition.x), Stage.random(-this.size.height, this.maxPosition.y));

I am not sure why you choose the range for the position to be [-particle.size .. stage.size - particle.size]. We allow the starting point to out of the stage from one limit but not from the other. I would expect the range to be:

[-particle.size .. stage.size]  or [(0,0) .. stage.size - particle.size].
Comment 3 Jon Lee 2016-03-16 19:45:02 PDT
Comment on attachment 274246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274246&action=review

>> PerformanceTests/Animometer/tests/dom/resources/leaves.js:6
>> +        stage.element.appendChild(this.element);
> 
> Utilities.createElement()?

Sure.

>> PerformanceTests/Animometer/tests/dom/resources/leaves.js:21
>> +        this._position = new Point(Stage.random(-this.size.width, this.maxPosition.x), Stage.random(-this.size.height, this.maxPosition.y));
> 
> I am not sure why you choose the range for the position to be [-particle.size .. stage.size - particle.size]. We allow the starting point to out of the stage from one limit but not from the other. I would expect the range to be:
> 
> [-particle.size .. stage.size]  or [(0,0) .. stage.size - particle.size].

You're right it should be 0,0 to stage.size - particle.size. Except in the case of the y-axis, the particles fall, so when they start they can be just above the top, so it should be -size.height.
Comment 4 Jon Lee 2016-03-16 19:49:09 PDT
Committed r198315: <http://trac.webkit.org/changeset/198315>