Bug 155570 – Add a new benchmark test

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jon Lee]

A harder version of leaves combines opacity and size.

[Jon Lee]

Created attachment 274246 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 274246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274246&action=review

> PerformanceTests/Animometer/tests/dom/resources/leaves.js:6
> +        stage.element.appendChild(this.element);

Utilities.createElement()?

> PerformanceTests/Animometer/tests/dom/resources/leaves.js:21
> +        this._position = new Point(Stage.random(-this.size.width, this.maxPosition.x), Stage.random(-this.size.height, this.maxPosition.y));

I am not sure why you choose the range for the position to be [-particle.size .. stage.size - particle.size]. We allow the starting point to out of the stage from one limit but not from the other. I would expect the range to be:

[-particle.size .. stage.size]  or [(0,0) .. stage.size - particle.size].

[Jon Lee]

Comment on attachment 274246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274246&action=review

>> PerformanceTests/Animometer/tests/dom/resources/leaves.js:6
>> +        stage.element.appendChild(this.element);
> 
> Utilities.createElement()?

Sure.

>> PerformanceTests/Animometer/tests/dom/resources/leaves.js:21
>> +        this._position = new Point(Stage.random(-this.size.width, this.maxPosition.x), Stage.random(-this.size.height, this.maxPosition.y));
> 
> I am not sure why you choose the range for the position to be [-particle.size .. stage.size - particle.size]. We allow the starting point to out of the stage from one limit but not from the other. I would expect the range to be:
> 
> [-particle.size .. stage.size]  or [(0,0) .. stage.size - particle.size].

You're right it should be 0,0 to stage.size - particle.size. Except in the case of the y-axis, the particles fall, so when they start they can be just above the top, so it should be -size.height.

[Jon Lee]

Committed r198315: <http://trac.webkit.org/changeset/198315>