Bug 15556 - REGRESSION: Fix last layout test failure (actually a crash) seen on trunk-mac-ppc-release
Summary: REGRESSION: Fix last layout test failure (actually a crash) seen on trunk-mac...
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nikolas Zimmermann
Keywords: Regression
: 15396 (view as bug list)
Depends on:
Reported: 2007-10-18 07:03 PDT by Nikolas Zimmermann
Modified: 2007-10-18 09:29 PDT (History)
2 users (show)

See Also:

Initial patch (9.87 KB, patch)
2007-10-18 07:06 PDT, Nikolas Zimmermann
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2007-10-18 07:03:10 PDT
ImageBuffers aren't clipped against the visible frame size (RenderView).
This leads to unnecessary large allocations, which may crash some machines in extreme cases like <mask width="10000"....

As this worked at some point, before the ImageBuffer restructurization, this is actually a regression, so P1.
Comment 1 Nikolas Zimmermann 2007-10-18 07:06:29 PDT
Created attachment 16722 [details]
Initial patch

Attached patch fixes crash - but not only for mask, but any ImageBuffer based content (ie. patterns, gradient on text, etc.)
Comment 2 Nikolas Zimmermann 2007-10-18 07:19:20 PDT
*** Bug 15396 has been marked as a duplicate of this bug. ***
Comment 3 Anders Carlsson 2007-10-18 08:23:46 PDT
Comment on attachment 16722 [details]
Initial patch

Comment 4 Nikolas Zimmermann 2007-10-18 08:31:08 PDT
Landed in r26745.
Comment 5 David Kilzer (:ddkilzer) 2007-10-18 09:29:53 PDT
Regression per Comment #0.