Bug 155557 - Web Inspector: Quick Open dialog has fuzzy icons at 1x
Summary: Web Inspector: Quick Open dialog has fuzzy icons at 1x
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-16 13:41 PDT by Joseph Pecoraro
Modified: 2016-03-23 13:08 PDT (History)
9 users (show)

See Also:

Attachments
[Image] Dialog with 16x16 icons (253.80 KB, image/png)
2016-03-16 16:59 PDT, Matt Baker 		no flags Details
[Patch] Proposed Fix (100.03 KB, patch)
2016-03-23 11:29 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] 32px 1x/2x icon set (36.22 KB, image/png)
2016-03-23 11:30 PDT, Matt Baker 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-16 13:41:33 PDT 
* SUMMARY
Quick Open dialog has fuzzy icons at 1x.

File icons are 16x16 being displayed at 24x24 size.

* STEPS TO REPRODUCE
1. Open Inspector
2. Show Quick Open Dialog (Cmd-Shift-O)
3. Type 't' to get results
  => fuzzy icons
Comment 1 Radar WebKit Bug Importer 2016-03-16 13:42:19 PDT 
<rdar://problem/25200217>
Comment 2 Timothy Hatcher 2016-03-16 14:40:41 PDT 
We can deviate from Xcode here and use 16x16 icons. I don't want to add larger icons just for this.
Comment 3 Matt Baker 2016-03-16 16:14:54 PDT 
(In reply to comment #2)
> We can deviate from Xcode here and use 16x16 icons. I don't want to add
> larger icons just for this.

Sounds good.
Comment 4 Matt Baker 2016-03-16 16:59:50 PDT 
Created attachment 274238 [details]
[Image] Dialog with 16x16 icons

Large tree items present better hit targets, but it looks odd with small icons.
Comment 5 Timothy Hatcher 2016-03-16 20:58:01 PDT 
Hmm. Yeah, that does look worse. Though I suspect most users will uses arrow keys and enter to pick an item, not the mouse.

Options:
1) Modifiy the UI to work with small icons, so smaller rows and input field to match.
2) Make 32x32 or 24x24 resource icons.
Comment 6 Matt Baker 2016-03-23 11:29:41 PDT 
Created attachment 274761 [details]
[Patch] Proposed Fix
Comment 7 Matt Baker 2016-03-23 11:30:35 PDT 
Created attachment 274762 [details]
[Image] 32px 1x/2x icon set
Comment 8 Joseph Pecoraro 2016-03-23 12:16:23 PDT 
Comment on attachment 274761 [details]
[Patch] Proposed Fix

We should file a bug on GTK notifying them they may want to adjust their icons.
Comment 9 Matt Baker 2016-03-23 12:42:37 PDT 
(In reply to comment #8)
> Comment on attachment 274761 [details]
> [Patch] Proposed Fix
> 
> We should file a bug on GTK notifying them they may want to adjust their
> icons.

https://bugs.webkit.org/show_bug.cgi?id=155802
Comment 10 WebKit Commit Bot 2016-03-23 13:08:48 PDT 
Comment on attachment 274761 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 274761

Committed r198590: <http://trac.webkit.org/changeset/198590>
Comment 11 WebKit Commit Bot 2016-03-23 13:08:52 PDT 
All reviewed patches have been landed.  Closing bug.