Need to keep _setDrawsTransparentBackground: around and working for now
Created attachment 274201 [details] Patch
Comment on attachment 274201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review > Source/WebKit2/ChangeLog:3 > + Need to keep _setDrawsTransparentBackground: around and working for now A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank”
Comment on attachment 274201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188 > + static bool hasLoggedDeprecationWarning; Strange mix of C bool… > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191 > + hasLoggedDeprecationWarning = YES; …with Objective-C YES.
Comment on attachment 274201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review >> Source/WebKit2/ChangeLog:3 >> + Need to keep _setDrawsTransparentBackground: around and working for now > > A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank” OK! >> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191 >> + hasLoggedDeprecationWarning = YES; > > …with Objective-C YES. Fair!
Created attachment 274202 [details] Patch
Comment on attachment 274202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274202&action=review > Source/WebKit2/ChangeLog:8 > + Might be useful to explain here how this fixes the bug. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188 > + static BOOL hasLoggedDeprecationWarning; Would be good to have a comment referencing this bug here so that people can easily answer the question why this is here and whether it’s OK to remove it.
Created attachment 274207 [details] Patch
Comment on attachment 274207 [details] Patch Clearing flags on attachment: 274207 Committed r198298: <http://trac.webkit.org/changeset/198298>
All reviewed patches have been landed. Closing bug.