Bug 155550 - REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank
Summary: REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-16 11:26 PDT by Tim Horton
Modified: 2016-03-16 13:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2016-03-16 11:33 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2016-03-16 11:40 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2016-03-16 12:15 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-03-16 11:26:06 PDT 
Need to keep _setDrawsTransparentBackground: around and working for now
Comment 1 Tim Horton 2016-03-16 11:33:19 PDT 
Created attachment 274201 [details]
Patch
Comment 2 mitz 2016-03-16 11:35:14 PDT 
Comment on attachment 274201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review

> Source/WebKit2/ChangeLog:3
> +        Need to keep _setDrawsTransparentBackground: around and working for now

A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank”
Comment 3 mitz 2016-03-16 11:36:12 PDT 
Comment on attachment 274201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188
> +    static bool hasLoggedDeprecationWarning;

Strange mix of C bool…

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191
> +        hasLoggedDeprecationWarning = YES;

…with Objective-C YES.
Comment 4 Tim Horton 2016-03-16 11:37:59 PDT 
Comment on attachment 274201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274201&action=review

>> Source/WebKit2/ChangeLog:3
>> +        Need to keep _setDrawsTransparentBackground: around and working for now
> 
> A better title here would be “REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank”

OK!

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4191
>> +        hasLoggedDeprecationWarning = YES;
> 
> …with Objective-C YES.

Fair!
Comment 5 Tim Horton 2016-03-16 11:40:45 PDT 
Created attachment 274202 [details]
Patch
Comment 6 mitz 2016-03-16 11:42:31 PDT 
Comment on attachment 274202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274202&action=review

> Source/WebKit2/ChangeLog:8
> +

Might be useful to explain here how this fixes the bug.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4188
> +    static BOOL hasLoggedDeprecationWarning;

Would be good to have a comment referencing this bug here so that people can easily answer the question why this is here and whether it’s OK to remove it.
Comment 7 Tim Horton 2016-03-16 12:15:07 PDT 
Created attachment 274207 [details]
Patch
Comment 8 WebKit Commit Bot 2016-03-16 13:16:46 PDT 
Comment on attachment 274207 [details]
Patch

Clearing flags on attachment: 274207

Committed r198298: <http://trac.webkit.org/changeset/198298>
Comment 9 WebKit Commit Bot 2016-03-16 13:16:50 PDT 
All reviewed patches have been landed.  Closing bug.