Bug 155548 - Implement document.queryCommandSupported("copy")
Summary: Implement document.queryCommandSupported("copy")
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar, WebExposed
Depends on: 146336
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-16 10:34 PDT by David Graham
Modified: 2016-03-17 14:29 PDT (History)
7 users (show)

See Also:


Attachments
Patch (21.88 KB, patch)
2016-03-16 14:46 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.05 MB, application/zip)
2016-03-16 15:33 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (984.09 KB, application/zip)
2016-03-16 15:36 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (699.85 KB, application/zip)
2016-03-16 15:39 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.32 MB, application/zip)
2016-03-16 15:54 PDT, Build Bot
no flags Details
Patch (21.90 KB, patch)
2016-03-17 11:00 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (907.32 KB, application/zip)
2016-03-17 11:46 PDT, Build Bot
no flags Details
Patch (22.73 KB, patch)
2016-03-17 11:51 PDT, Sam Weinig
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Graham 2016-03-16 10:34:20 PDT
Clipboard copy via document.execCommand("copy") was implemented in #146336. Testing browser support for this feature with document.queryCommandSupported("copy") would be ideal, but it currently returns false. Can this be changed to return true now that copy has been implemented in nightly builds?

Thanks!
Comment 1 Radar WebKit Bug Importer 2016-03-16 10:37:03 PDT
<rdar://problem/25195295>
Comment 2 Sam Weinig 2016-03-16 14:46:26 PDT
Created attachment 274221 [details]
Patch
Comment 3 Enrica Casucci 2016-03-16 14:53:03 PDT
Comment on attachment 274221 [details]
Patch

Looks good.
Comment 4 Build Bot 2016-03-16 15:33:27 PDT
Comment on attachment 274221 [details]
Patch

Attachment 274221 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/990776

New failing tests:
editing/mac/pasteboard/text-precomposed.html
accessibility/mac/caret-browsing-arrow-nav.html
fast/events/backspace-navigates-back.html
editing/selection/caret-mode-document-begin-end.html
platform/mac/fast/events/objc-event-api.html
fast/forms/input-appearance-readonly.html
fast/events/scroll-after-click-on-tab-index.html
editing/selection/programmatic-selection-on-mac-is-directionless.html
editing/execCommand/16049.html
fast/text/text-combine-crash.html
editing/selection/selection-actions.html
Comment 5 Build Bot 2016-03-16 15:33:30 PDT
Created attachment 274226 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-03-16 15:36:35 PDT
Comment on attachment 274221 [details]
Patch

Attachment 274221 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/990781

New failing tests:
accessibility/mac/caret-browsing-arrow-nav.html
fast/events/backspace-navigates-back.html
fast/forms/input-appearance-readonly.html
fast/events/scroll-after-click-on-tab-index.html
editing/execCommand/16049.html
fast/text/text-combine-crash.html
editing/selection/selection-actions.html
Comment 7 Build Bot 2016-03-16 15:36:38 PDT
Created attachment 274227 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-03-16 15:39:32 PDT
Comment on attachment 274221 [details]
Patch

Attachment 274221 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/990775

New failing tests:
editing/execCommand/16049.html
fast/text/text-combine-crash.html
editing/selection/selection-actions.html
Comment 9 Build Bot 2016-03-16 15:39:35 PDT
Created attachment 274228 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-03-16 15:54:03 PDT
Comment on attachment 274221 [details]
Patch

Attachment 274221 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/990794

New failing tests:
editing/mac/pasteboard/text-precomposed.html
accessibility/mac/caret-browsing-arrow-nav.html
fast/events/backspace-navigates-back.html
editing/selection/caret-mode-document-begin-end.html
fast/lists/list-marker-remove-crash.html
platform/mac/fast/events/objc-event-api.html
fast/forms/input-appearance-readonly.html
fast/block/layer-not-removed-from-parent-crash.html
fast/events/scroll-after-click-on-tab-index.html
editing/selection/programmatic-selection-on-mac-is-directionless.html
editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html
editing/execCommand/16049.html
fast/text/text-combine-crash.html
editing/selection/selection-actions.html
Comment 11 Build Bot 2016-03-16 15:54:06 PDT
Created attachment 274230 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 12 Alexey Proskuryakov 2016-03-16 20:32:37 PDT
Thank you for waiting for EWS!
Comment 13 Sam Weinig 2016-03-17 11:00:56 PDT
Created attachment 274301 [details]
Patch
Comment 14 Build Bot 2016-03-17 11:45:58 PDT
Comment on attachment 274301 [details]
Patch

Attachment 274301 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/995248

New failing tests:
editing/mac/pasteboard/text-precomposed.html
Comment 15 Build Bot 2016-03-17 11:46:02 PDT
Created attachment 274303 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 16 Sam Weinig 2016-03-17 11:51:58 PDT
Created attachment 274306 [details]
Patch
Comment 17 Sam Weinig 2016-03-17 14:04:52 PDT
Committed r198354: <http://trac.webkit.org/changeset/198354>