Bug 155542 - Add support for movablelimits
Summary: Add support for movablelimits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on: 133845
Blocks: displaystyle
  Show dependency tree / graph
 
Reported: 2016-03-16 08:08 PDT by Frédéric Wang (:fredw)
Modified: 2016-07-08 00:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (WIP) (15.27 KB, patch)
2016-03-16 08:08 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
testcase (15.27 KB, patch)
2016-03-16 08:09 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
testcase (1018 bytes, text/html)
2016-03-16 08:09 PDT, Frédéric Wang (:fredw) 		no flags Details
Patch (45.53 KB, patch)
2016-03-17 01:29 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (47.65 KB, patch)
2016-04-26 09:01 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (47.61 KB, patch)
2016-06-25 00:38 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (46.29 KB, patch)
2016-07-07 23:04 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-03-16 08:08:39 PDT 
Created attachment 274190 [details]
Patch (WIP)

When the base of an munderover/munder/mover element is an operator with the movablelimits=true property in displaystyle=false ; it should render the same as the equivalent msubsup/msub/sup. After the MathML refactoring, it is easy: we essentially need to make RenderMathMLUnderOver inherits from RenderMathMLScripts. This actually allows to share more code between the two classes.

I'm attaching a WIP patch. I plan to add new tests and to test it on mac too tomorrow.
Comment 1 Frédéric Wang (:fredw) 2016-03-16 08:09:06 PDT 
Created attachment 274191 [details]
testcase
Comment 2 Frédéric Wang (:fredw) 2016-03-16 08:09:52 PDT 
Created attachment 274192 [details]
testcase
Comment 3 Frédéric Wang (:fredw) 2016-03-17 01:29:06 PDT 
Created attachment 274270 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2016-04-26 09:01:47 PDT 
Created attachment 277379 [details]
Patch
Comment 5 Frédéric Wang (:fredw) 2016-06-25 00:38:30 PDT 
Created attachment 282053 [details]
Patch
Comment 6 Brent Fulgham 2016-07-07 14:05:28 PDT 
Comment on attachment 282053 [details]
Patch

These changes seem okay. Please confirm tests pass with these updates in place before landing.
Comment 7 Frédéric Wang (:fredw) 2016-07-07 23:04:31 PDT 
Created attachment 283111 [details]
Patch
Comment 8 Frédéric Wang (:fredw) 2016-07-08 00:16:09 PDT 
Committed r202970: <http://trac.webkit.org/changeset/202970>