Bug 155541 - Don't invalidate style unnecessarily when setting inline style cssText
Summary: Don't invalidate style unnecessarily when setting inline style cssText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-16 07:10 PDT by Antti Koivisto
Modified: 2016-03-16 09:46 PDT (History)
3 users (show)

See Also:

Attachments
patch (8.75 KB, patch)
2016-03-16 07:55 PDT, Antti Koivisto 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-03-16 07:10:49 PDT 
We should check if something actually changes.
Comment 1 Antti Koivisto 2016-03-16 07:11:18 PDT 
rdar://problem/23318893
Comment 2 Antti Koivisto 2016-03-16 07:55:03 PDT 
Created attachment 274189 [details]
patch
Comment 3 Simon Fraser (smfr) 2016-03-16 08:44:53 PDT 
Comment on attachment 274189 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274189&action=review

> Source/WebCore/css/StyleProperties.cpp:859
> +    return oldProperties != m_propertyVector;

Are they always sorted the same way? If not, this is conservative check, but maybe add a comment to mention that.
Comment 4 Antti Koivisto 2016-03-16 09:41:38 PDT 
> Are they always sorted the same way? If not, this is conservative check, but
> maybe add a comment to mention that.

No they are not. Added a comment.
Comment 5 Antti Koivisto 2016-03-16 09:46:32 PDT 
https://trac.webkit.org/r198284