Bug 155519 - Follow up to r195769
Summary: Follow up to r195769
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-15 16:25 PDT by Enrica Casucci
Modified: 2016-03-15 17:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2016-03-15 16:33 PDT, Enrica Casucci 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2016-03-15 16:25:58 PDT 
For some types of data detector links we choose not to perform the default action. Therefore we don't generate a synthetic click on tap.
There are to code paths that lead to calling handleSyntheticClick that need to be guarded with this logic.
Only one was covered in r195769.

rdar://problem/25146483
Comment 1 Enrica Casucci 2016-03-15 16:33:21 PDT 
Created attachment 274152 [details]
Patch
Comment 2 Tim Horton 2016-03-15 16:44:43 PDT 
Comment on attachment 274152 [details]
Patch

Is this testable?
Comment 3 Enrica Casucci 2016-03-15 16:57:24 PDT 
(In reply to comment #2)
> Comment on attachment 274152 [details]
> Patch
> 
> Is this testable?
I wouldn't know how. The two code paths are triggered depending on the duration of the tap vs touch.
Comment 4 Enrica Casucci 2016-03-15 17:02:04 PDT 
Committed revision 198245.