WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155519
Follow up to
r195769
https://bugs.webkit.org/show_bug.cgi?id=155519
Summary
Follow up to r195769
Enrica Casucci
Reported
2016-03-15 16:25:58 PDT
For some types of data detector links we choose not to perform the default action. Therefore we don't generate a synthetic click on tap. There are to code paths that lead to calling handleSyntheticClick that need to be guarded with this logic. Only one was covered in
r195769
.
rdar://problem/25146483
Attachments
Patch
(2.33 KB, patch)
2016-03-15 16:33 PDT
,
Enrica Casucci
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Enrica Casucci
Comment 1
2016-03-15 16:33:21 PDT
Created
attachment 274152
[details]
Patch
Tim Horton
Comment 2
2016-03-15 16:44:43 PDT
Comment on
attachment 274152
[details]
Patch Is this testable?
Enrica Casucci
Comment 3
2016-03-15 16:57:24 PDT
(In reply to
comment #2
)
> Comment on
attachment 274152
[details]
> Patch > > Is this testable?
I wouldn't know how. The two code paths are triggered depending on the duration of the tap vs touch.
Enrica Casucci
Comment 4
2016-03-15 17:02:04 PDT
Committed revision 198245.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug