Bug 155512 - [JSC] Help clang generate better code on arrayProtoFuncToString()
Summary: [JSC] Help clang generate better code on arrayProtoFuncToString()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-15 14:16 PDT by Benjamin Poulain
Modified: 2016-03-15 19:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.82 KB, patch)
2016-03-15 14:28 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (962.76 KB, application/zip)
2016-03-15 15:31 PDT, Build Bot 		no flags Details
Patch (8.88 KB, patch)
2016-03-15 17:15 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-03-15 14:16:28 PDT 
[JSC] Help clang generate better code on arrayProtoFuncToString()
Comment 1 Benjamin Poulain 2016-03-15 14:28:54 PDT 
Created attachment 274129 [details]
Patch
Comment 2 Benjamin Poulain 2016-03-15 14:35:31 PDT 
Uh, that removed 12k from the binary. That's probably the changes in jsMakeNontrivialString().
Comment 3 Mark Lam 2016-03-15 14:38:39 PDT 
Comment on attachment 274129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274129&action=review

r=me

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:327
> -    if (exec->hadException())
> +    if (UNLIKELY(exec->hadException()))

Let's cache the VM above and use vm.exception() in the check here and below.
Comment 4 Build Bot 2016-03-15 15:31:40 PDT 
Comment on attachment 274129 [details]
Patch

Attachment 274129 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/985303

New failing tests:
js/function-call-aliased.html
Comment 5 Build Bot 2016-03-15 15:31:42 PDT 
Created attachment 274146 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Benjamin Poulain 2016-03-15 17:15:58 PDT 
Created attachment 274161 [details]
Patch
Comment 7 WebKit Commit Bot 2016-03-15 19:16:26 PDT 
Comment on attachment 274161 [details]
Patch

Clearing flags on attachment: 274161

Committed r198256: <http://trac.webkit.org/changeset/198256>
Comment 8 WebKit Commit Bot 2016-03-15 19:16:30 PDT 
All reviewed patches have been landed.  Closing bug.