Bug 155510 - Silence leaks in ParkingLot
Summary: Silence leaks in ParkingLot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-15 14:02 PDT by Filip Pizlo
Modified: 2016-03-17 11:54 PDT (History)
5 users (show)

See Also:

Attachments
the patch (6.85 KB, patch)
2016-03-15 14:07 PDT, Filip Pizlo 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-03-15 14:02:12 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-03-15 14:07:49 PDT 
Created attachment 274125 [details]
the patch
Comment 2 Alexey Proskuryakov 2016-03-15 14:13:06 PDT 
Comment on attachment 274125 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274125&action=review

> Source/WTF/wtf/ParkingLot.cpp:183
> +Vector<Hashtable*>* hashtables;

Should this be static?
Comment 3 Filip Pizlo 2016-03-15 14:13:44 PDT 
(In reply to comment #2)
> Comment on attachment 274125 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274125&action=review
> 
> > Source/WTF/wtf/ParkingLot.cpp:183
> > +Vector<Hashtable*>* hashtables;
> 
> Should this be static?

The whole thing is in an anonymous namespace, so it doesn't have to be.
Comment 4 Alexey Proskuryakov 2016-03-15 14:31:36 PDT 
Indeed. See also: <https://lists.macosforge.org/pipermail/webkit-dev/2011-October/018303.html>.
Comment 5 Filip Pizlo 2016-03-17 11:54:46 PDT 
Landed in http://trac.webkit.org/changeset/198345