Bug 155500 - Change some release asserts in CodeBlock linking into debug asserts
Summary: Change some release asserts in CodeBlock linking into debug asserts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-15 12:01 PDT by Saam Barati
Modified: 2016-03-30 17:47 PDT (History)
11 users (show)

See Also:

Attachments
patch (6.17 KB, patch)
2016-03-15 13:44 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (6.19 KB, patch)
2016-03-15 13:49 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-03-15 12:01:24 PDT 
...
Comment 1 Saam Barati 2016-03-15 13:44:57 PDT 
Created attachment 274122 [details]
patch
Comment 2 Filip Pizlo 2016-03-15 13:46:39 PDT 
Comment on attachment 274122 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274122&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1865
> +#ifndef NDEBUG

#if !ASSERT_DISABLED

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1869
> +#ifndef NDEBUG

Ditto.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1883
> +#ifndef NDEBUG

Ditto.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2085
> +#ifndef NDEBUG

Ditto.
Comment 3 Saam Barati 2016-03-15 13:49:44 PDT 
Created attachment 274123 [details]
patch
Comment 4 WebKit Commit Bot 2016-03-30 17:47:13 PDT 
Comment on attachment 274123 [details]
patch

Clearing flags on attachment: 274123

Committed r198868: <http://trac.webkit.org/changeset/198868>
Comment 5 WebKit Commit Bot 2016-03-30 17:47:17 PDT 
All reviewed patches have been landed.  Closing bug.