Bug 155480 - AX: certain elements not included in accessibility tree
Summary: AX: certain elements not included in accessibility tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 9
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-14 18:10 PDT by chris fleizach
Modified: 2016-03-15 12:03 PDT (History)
10 users (show)

See Also:


Attachments
patch (5.25 KB, patch)
2016-03-15 09:04 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (5.24 KB, patch)
2016-03-15 09:11 PDT, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2016-03-14 18:10:32 PDT
There exists web content where our algorithm for determining whats the next element skips content.

The case this happens in is if you have two nested inlines with continuations and the sub-child has no next sibling. we do not check its parent in that case for its next sibling

this can result in whole blocks of inaccessible content

<rdar://problem/19727062>
Comment 1 chris fleizach 2016-03-15 09:04:04 PDT
Created attachment 274094 [details]
patch
Comment 2 chris fleizach 2016-03-15 09:11:58 PDT
Created attachment 274098 [details]
patch
Comment 3 Beth Dakin 2016-03-15 10:59:02 PDT
Comment on attachment 274098 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274098&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:391
> +    // Case 5.1: After case 4, (the element was inline w/ continuation but had no sibling), then check it's parent.

I'm not convinced that this numbering scheme makes sense! :-P
Comment 4 chris fleizach 2016-03-15 11:12:46 PDT
Comment on attachment 274098 [details]
patch

i was going to use 5a, but that was already taken =/
Comment 5 WebKit Commit Bot 2016-03-15 12:02:58 PDT
Comment on attachment 274098 [details]
patch

Clearing flags on attachment: 274098

Committed r198219: <http://trac.webkit.org/changeset/198219>
Comment 6 WebKit Commit Bot 2016-03-15 12:03:04 PDT
All reviewed patches have been landed.  Closing bug.