Bug 155478 – Web Inspector: No way to see a path to a root for instances in the Heap Snapshot content view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Show path from root to instances in the Heap Snapshot content view.

When hovering the @1234 object identifier in the UI, show a popover that displays the shortest path from the root (typically Window) to the instance. When looking for leaks, this is an important way to understand exactly why the object is being kept alive.

[Radar WebKit Bug Importer]

<rdar://problem/25157408>

[Joseph Pecoraro]

Created attachment 274063 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 274064 [details]
[IMAGE] Simple Path

[Joseph Pecoraro]

Created attachment 274065 [details]
[IMAGE] More Complex Path

[Joseph Pecoraro]

The images were taken when I was using an eye icon. That is no longer accurate, I switched to just hovering the object-id, @1234, to get the popover.

[Joseph Pecoraro]

Created attachment 274066 [details]
[PATCH] Proposed Fix

Rebaselined.

[Timothy Hatcher]

Comment on attachment 274066 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=274066&action=review

> Source/WebInspectorUI/UserInterface/Models/HeapSnapshotRootPath.js:120
> +        let component = this._canPropertyNameBeDotAccess(propertyName) ? "." + propertyName : "[" + doubleQuotedString(propertyName) + "]";

Slick.

> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css:130
> +    white-space: pre;

Why pre?

[WebKit Commit Bot]

Comment on attachment 274066 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 274066

Committed r198196: <http://trac.webkit.org/changeset/198196>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.