Bug 155463 - [WinCairo] Compile fix.
Summary: [WinCairo] Compile fix.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2016-03-14 14:15 PDT by peavo
Modified: 2016-03-15 09:57 PDT (History)
6 users (show)

See Also:

Patch (1.36 KB, patch)
2016-03-14 14:22 PDT, peavo
no flags Details | Formatted Diff | Diff
Patch (3.60 KB, patch)
2016-03-14 15:57 PDT, peavo
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-03-14 14:15:28 PDT
We need to provide a session id when constructing a NetworkStorageSession object.
Comment 1 peavo 2016-03-14 14:22:03 PDT
Created attachment 274027 [details]
Comment 2 Alex Christensen 2016-03-14 14:31:54 PDT
Is there a way we could use the same LOCAL_SESSION definition as everyone else in WinCairo?
Comment 3 peavo 2016-03-14 14:51:17 PDT
(In reply to comment #2)
> Is there a way we could use the same LOCAL_SESSION definition as everyone
> else in WinCairo?

Yes, I think so. I will look into it :)
Comment 4 peavo 2016-03-14 15:57:16 PDT
Created attachment 274045 [details]
Comment 5 Alex Christensen 2016-03-14 21:51:26 PDT
Comment on attachment 274045 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=274045&action=review

Ahhh, that feels so much better.

> Source/WebCore/loader/CookieJar.cpp:56
>  #define LOCAL_SESSION(document) NetworkStorageSession& session = storageSession(document);

We could probably even get rid of this, too.  auto session = storageSession(document)
Comment 6 Alex Christensen 2016-03-14 21:59:51 PDT
Comment 7 Alex Christensen 2016-03-14 22:26:06 PDT
Cleanup in https://bugs.webkit.org/show_bug.cgi?id=155484
Comment 8 Alex Christensen 2016-03-14 22:32:51 PDT
Build fix in http://trac.webkit.org/changeset/198197
Comment 9 peavo 2016-03-15 09:57:23 PDT
Thank you!