Bug 155451 - [ES6] Disallow var assignments in for-in loops
Summary: [ES6] Disallow var assignments in for-in loops
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
Depends on: 155518 159478
  Show dependency treegraph
Reported: 2016-03-14 11:54 PDT by Saam Barati
Modified: 2016-07-06 11:32 PDT (History)
11 users (show)

See Also:

patch (6.28 KB, patch)
2016-03-14 12:02 PDT, Saam Barati
mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (6.32 KB, patch)
2016-03-30 16:02 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-03-14 11:54:19 PDT
This is what the spec dictates, but last time we made this change, some websites that we care about broke.
Lets try making it again, and if things break we will roll it out.
Comment 1 Saam Barati 2016-03-14 12:02:18 PDT
Created attachment 273998 [details]
Comment 2 Mark Lam 2016-03-14 12:04:09 PDT
Comment on attachment 273998 [details]

Comment 3 Saam Barati 2016-03-14 12:40:05 PDT
landed in:
Comment 4 WebKit Commit Bot 2016-03-15 15:35:57 PDT
Re-opened since this is blocked by bug 155518
Comment 5 Saam Barati 2016-03-30 16:02:20 PDT
Created attachment 275231 [details]
patch for landing
Comment 6 WebKit Commit Bot 2016-03-31 16:07:37 PDT
Comment on attachment 275231 [details]
patch for landing

Clearing flags on attachment: 275231

Committed r198928: <http://trac.webkit.org/changeset/198928>
Comment 7 WebKit Commit Bot 2016-03-31 16:07:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Yusuke Suzuki 2016-04-03 09:50:59 PDT
Committed r198985: <http://trac.webkit.org/changeset/198985>
Comment 9 WebKit Commit Bot 2016-07-06 11:19:52 PDT
Re-opened since this is blocked by bug 159478
Comment 10 Saam Barati 2016-07-06 11:32:34 PDT
This breaks websites, so we're not going to land it