Bug 155448 - [ES6] Make JSON.stringify ES6 compatible
Summary: [ES6] Make JSON.stringify ES6 compatible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-14 11:43 PDT by Saam Barati
Modified: 2016-03-14 13:07 PDT (History)
11 users (show)

See Also:


Attachments
patch (6.73 KB, patch)
2016-03-14 12:45 PDT, Saam Barati
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-03-14 11:43:43 PDT
...
Comment 1 Saam Barati 2016-03-14 12:45:32 PDT
Created attachment 274001 [details]
patch
Comment 2 WebKit Commit Bot 2016-03-14 12:46:57 PDT
Attachment 274001 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSONObject.cpp:114:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2016-03-14 12:51:51 PDT
Comment on attachment 274001 [details]
patch

r=me.  As discussed offline, please add test to verify that it is also ok for toJSON to be a proxy of a function.
Comment 4 Saam Barati 2016-03-14 13:07:40 PDT
thanks for the reviews.
landed in:
http://trac.webkit.org/changeset/198150