WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155448
[ES6] Make JSON.stringify ES6 compatible
https://bugs.webkit.org/show_bug.cgi?id=155448
Summary
[ES6] Make JSON.stringify ES6 compatible
Saam Barati
Reported
2016-03-14 11:43:43 PDT
...
Attachments
patch
(6.73 KB, patch)
2016-03-14 12:45 PDT
,
Saam Barati
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2016-03-14 12:45:32 PDT
Created
attachment 274001
[details]
patch
WebKit Commit Bot
Comment 2
2016-03-14 12:46:57 PDT
Attachment 274001
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSONObject.cpp:114: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3
2016-03-14 12:51:51 PDT
Comment on
attachment 274001
[details]
patch r=me. As discussed offline, please add test to verify that it is also ok for toJSON to be a proxy of a function.
Saam Barati
Comment 4
2016-03-14 13:07:40 PDT
thanks for the reviews. landed in:
http://trac.webkit.org/changeset/198150
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug