This function is required to fix compilation after r197687.
Created attachment 273953 [details] Patch
Comment on attachment 273953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273953&action=review > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2504 > + m_assembler.mtc1(MIPSRegisters::zero, reg); This will set to 0 only one FP register, which is not enough for double precision. I think it would be easier to put something like this: convertInt32ToDouble(MIPSRegisters::zero, reg); I also thought of this, but I'm not sure it's a good idea: subDouble(reg, reg);
Konstantin, are you still planning to work on this?
Yes, starting now. Sorry for being late
(In reply to comment #4) > Yes, starting now. Sorry for being late No worries! It was just to know if I should take over on that. Thanks for taking care of it!
Created attachment 276554 [details] Patch
I've checked subDouble(reg, reg) and found that it fails to zero reg with INFINITY or NAN. So the only remaining option is convertInt32ToDouble(MIPSRegisters::zero, reg).
Comment on attachment 276554 [details] Patch Clearing flags on attachment: 276554 Committed r199626: <http://trac.webkit.org/changeset/199626>
All reviewed patches have been landed. Closing bug.