RESOLVED FIXED 155426
REGRESSION (r196803): [GTK] Cannot see tweet details after r196803 
https://bugs.webkit.org/show_bug.cgi?id=155426
Summary REGRESSION (r196803): [GTK] Cannot see tweet details after r196803
Alberto Garcia
Reported 2016-03-14 02:13:02 PDT
1. Launch the MiniBrowser and go to e.g. https://twitter.com/webkit 2. Click on a tweet to see its details. Expected outcome: there's a pop-up window with the selected tweet. Actual outcome: the main window is dimmed but no pop-up appears. The address bar shows the URL of the selected tweet (https://twitter.com/webkit/status/...) This happens with 2.10.8 (tested in Debian and Arch Linux), but I haven't been able to reproduce it with 2.10.6 or 2.11.90. This does not happen with all tweets. I can reproduced it with this one from March the 2nd: "After reaching consensus on Custom Elements API, we will begin implementing without a prefix and enabled by default".
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-03-14 02:19:29 PDT
We need to run a bisect in 2.10 branch then
Carlos Garcia Campos
Comment 2 2016-03-14 09:28:50 PDT
Ok, this is not 2.10 specific, I can reproduce it with MB in trunk and 2.12 and with ephy depending in the window size. I can confirm this never happens reverting r196803. So, I suspect it has to do with the visible content size reporting, or the layer size/positioning.
Carlos Garcia Campos
Comment 3 2016-03-14 09:51:50 PDT
Yes, it seems it has to do with the visible rectangle. If you open the MB and make the window larger, the popup works until you scroll more than ~ 500
Michael Catanzaro
Comment 4 2016-03-14 11:08:49 PDT
This page is also broken with 2.10.8, but not with 2.10.7: http://blog.twshodgson.co.uk/2015/02/23/pandoc-beamer-template/ It's probably the same bug.
Carlos Garcia Campos
Comment 5 2016-03-15 01:51:52 PDT
(In reply to comment #4) > This page is also broken with 2.10.8, but not with 2.10.7: > > http://blog.twshodgson.co.uk/2015/02/23/pandoc-beamer-template/ > > It's probably the same bug. Yes, reverting r196803 also fixes that.
Alberto Garcia
Comment 6 2016-03-15 02:05:05 PDT
Maybe related to this, I also noticed that the top bar on Facebook disappears after scrolling up and down a few times. I think you need an account in order to reproduce this.
Carlos Garcia Campos
Comment 7 2016-03-15 05:27:39 PDT
I've tried to figure out what the problem is, but I haven't been able to fix anything. It seems to be related with the visible contents rect transformation. In some cases, just returning the contents rect, like we do for the non composited contents layer, fixes the problem, but I don't really know why. Yoon has told me that he won't be able to look at this during this week, so I'm not sure what to do. The problem fixed by r196803 was very serious, but it has introduced more regressions than what we thought. Not only the ones mentioned here, we are also affected by bug #154912, for example, and I'm pretty sure more issues will be reported once we release 2.12. So, the question is whether we have broken more sites than fixed. In some cases the regressions are in popular web sites like twitter or facebook. What do you think? Is there anybody else apart from Yoon who could take a look at the issue?
Michael Catanzaro
Comment 8 2016-03-15 09:21:15 PDT
I guess roll it out, release 2.10.9, and release again once we get it fixed again. It's a tough call because it fixes by far our most serious bug, but the sites that bug occurs on are much less popular than Twitter, I think we should prioritize Twitter.
Carlos Garcia Campos
Comment 9 2016-03-16 00:18:57 PDT
Rolled out in r198266.
Michael Catanzaro
Comment 10 2016-03-17 06:28:10 PDT
*** Bug 154879 has been marked as a duplicate of this bug. ***
Michael Catanzaro
Comment 11 2016-03-20 08:13:25 PDT
*** Bug 155059 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.