Bug 155425 - Web Inspector: Reduce unnecessary dashboard repaints
Summary: Web Inspector: Reduce unnecessary dashboard repaints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-13 23:45 PDT by Nikita Vasilyev
Modified: 2016-03-14 04:38 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2016-03-13 23:48 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-03-13 23:45:39 PDT 
https://github.com/WebKit/webkit/blob/c31a868df2acf45ef91ca6390c06ef2aca7e90e4/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js#L104-L111

        Object.defineProperty(item, "text", {
            set: function(newText)
            {
                if (newText === item.outlet.textContent)
                    return;
                item.outlet.textContent = newText;
            }
        });

`newText` is always a number for console log, warning, and error counters.
Comment 1 Radar WebKit Bug Importer 2016-03-13 23:46:03 PDT 
<rdar://problem/25138247>
Comment 2 Nikita Vasilyev 2016-03-13 23:48:51 PDT 
Created attachment 273930 [details]
Patch
Comment 3 WebKit Commit Bot 2016-03-14 04:38:00 PDT 
Comment on attachment 273930 [details]
Patch

Clearing flags on attachment: 273930

Committed r198113: <http://trac.webkit.org/changeset/198113>
Comment 4 WebKit Commit Bot 2016-03-14 04:38:04 PDT 
All reviewed patches have been landed.  Closing bug.