WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155417
Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
https://bugs.webkit.org/show_bug.cgi?id=155417
Summary
Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
Joseph Pecoraro
Reported
2016-03-13 18:48:37 PDT
* SUMMARY Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards. - It is always enabled on all ports and has no known bugs. - Some ports have already shipped a release with it enabled. Lets drop the compile flag and enable always!
Attachments
[PATCH] Proposed Fix
(69.27 KB, patch)
2016-03-13 18:49 PDT
,
Joseph Pecoraro
ysuzuki
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
[PATCH] Proposed Fix
(69.23 KB, patch)
2016-03-13 20:51 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2016-03-13 18:49:32 PDT
Created
attachment 273915
[details]
[PATCH] Proposed Fix
WebKit Commit Bot
Comment 2
2016-03-13 18:51:21 PDT
Attachment 273915
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0: Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py. [featuredefines/new] [5] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3
2016-03-13 18:54:37 PDT
Comment on
attachment 273915
[details]
[PATCH] Proposed Fix r=me!
WebKit Commit Bot
Comment 4
2016-03-13 18:55:52 PDT
Comment on
attachment 273915
[details]
[PATCH] Proposed Fix Rejecting
attachment 273915
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 273915, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output:
http://webkit-queues.webkit.org/results/974002
Yusuke Suzuki
Comment 5
2016-03-13 19:26:56 PDT
Comment on
attachment 273915
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=273915&action=review
> Source/WebCore/ChangeLog:8 > + No new tests (OOPS!).
Let's drop this line.
Joseph Pecoraro
Comment 6
2016-03-13 20:51:51 PDT
Created
attachment 273920
[details]
[PATCH] Proposed Fix
WebKit Commit Bot
Comment 7
2016-03-13 21:52:47 PDT
Comment on
attachment 273920
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 273920 Committed
r198093
: <
http://trac.webkit.org/changeset/198093
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug