Bug 155417 – Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

* SUMMARY
Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards.

- It is always enabled on all ports and has no known bugs.
- Some ports have already shipped a release with it enabled.

Lets drop the compile flag and enable always!

[Joseph Pecoraro]

Created attachment 273915 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Attachment 273915 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py.  [featuredefines/new] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Comment on attachment 273915 [details]
[PATCH] Proposed Fix

r=me!

[WebKit Commit Bot]

Comment on attachment 273915 [details]
[PATCH] Proposed Fix

Rejecting attachment 273915 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 273915, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/974002

[Yusuke Suzuki]

Comment on attachment 273915 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273915&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Let's drop this line.

[Joseph Pecoraro]

Created attachment 273920 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 273920 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 273920

Committed r198093: <http://trac.webkit.org/changeset/198093>