<attachment> should be a runtime-enabled feature
<rdar://problem/25120753>
Created attachment 273906 [details] Patch
Comment on attachment 273906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273906&action=review Should we have a test for the default behavior of each of these flags? (and to make sure that it actually disables it? since surely we have tests that enable it). Also, are you planning on writing the code to make the existing tests tests turn it on when you switch the default to NO? > Source/WebKit/mac/WebView/WebView.mm:2518 > + settings.setAttachmentElementEnabled([preferences attachmentElementEnabled]); So there was already a WebCore setting? I wonder how well it works!
Comment on attachment 273906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273906&action=review >> Source/WebKit/mac/WebView/WebView.mm:2518 >> + settings.setAttachmentElementEnabled([preferences attachmentElementEnabled]); > > So there was already a WebCore setting? I wonder how well it works! It works in my testing :)
(In reply to comment #3) > Comment on attachment 273906 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273906&action=review > > Should we have a test for the default behavior of each of these flags? (and > to make sure that it actually disables it? since surely we have tests that > enable it). > > Also, are you planning on writing the code to make the existing tests tests > turn it on when you switch the default to NO? Actually a new patch is coming that does both of these. You already wrote a test to exercise disabling. That's just now the default. Watch this space.
Created attachment 273908 [details] Patch
Created attachment 273911 [details] Patch
Created attachment 273912 [details] Patch
Created attachment 273913 [details] Patch
Comment on attachment 273908 [details] Patch Attachment 273908 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/973748 New failing tests: editing/pasteboard/copy-paste-attachment.html editing/pasteboard/drag-and-drop-attachment-contenteditable.html
Created attachment 273914 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Committed r198088: <http://trac.webkit.org/changeset/198088>
(In reply to comment #12) > Committed r198088: <http://trac.webkit.org/changeset/198088> It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit/mac/WebView/WebView.mm:2515:14: error: no member named 'setAttachmentElementEnabled' in 'WebCore::Settings' settings.setAttachmentElementEnabled([preferences attachmentElementEnabled]); ~~~~~~~~ ^
fix landed in http://trac.webkit.org/changeset/198328