Bug 155379 - [Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter
Summary: [Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-11 14:24 PST by Myles C. Maxfield
Modified: 2016-03-12 19:58 PST (History)
8 users (show)

See Also:

Attachments
Patch (41.60 KB, patch)
2016-03-11 14:25 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (41.44 KB, patch)
2016-03-11 23:39 PST, Myles C. Maxfield 		bdakin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-03-11 14:24:01 PST 
[Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter
Comment 1 Myles C. Maxfield 2016-03-11 14:25:20 PST 
Created attachment 273768 [details]
Patch
Comment 2 Beth Dakin 2016-03-11 17:29:25 PST 
Comment on attachment 273768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273768&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:43
> +typedef id ScrollerImpController;

I think that you should either not change these at all, or you should change these to the real names too:
ScrollbarPainterController -> NSScrollerImpPair

The same is probably true for the delegate.
Comment 3 Myles C. Maxfield 2016-03-11 23:39:48 PST 
Created attachment 273817 [details]
Patch
Comment 4 WebKit Commit Bot 2016-03-12 15:47:17 PST 
Comment on attachment 273817 [details]
Patch

Rejecting attachment 273817 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 273817, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/968357
Comment 5 Myles C. Maxfield 2016-03-12 19:58:29 PST 
Committed r198078: <http://trac.webkit.org/changeset/198078>