Bug 155379 – [Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Remove typedef from NSScrollerImp to ScrollbarPainter

[Myles C. Maxfield]

Created attachment 273768 [details]
Patch

[Beth Dakin]

Comment on attachment 273768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273768&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:43
> +typedef id ScrollerImpController;

I think that you should either not change these at all, or you should change these to the real names too:
ScrollbarPainterController -> NSScrollerImpPair

The same is probably true for the delegate.

[Myles C. Maxfield]

Created attachment 273817 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 273817 [details]
Patch

Rejecting attachment 273817 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 273817, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/968357

[Myles C. Maxfield]

Committed r198078: <http://trac.webkit.org/changeset/198078>