Bug 155374 – [AX] SVG element with child desc not exposed

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

[AX] SVG element with child desc not exposed

[Joanmarie Diggs]

Created attachment 273750 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/25114469>

[Darin Adler]

Comment on attachment 273750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273750&action=review

> Source/WebCore/accessibility/AccessibilitySVGElement.h:35
> +class AccessibilitySVGElement : public AccessibilityRenderObject {

Since the class is no longer final, best practice would be to mark the overrides of virtual functions here final, instead of override, unless we need to override them further in the derived class.

I believe that’s true for *all* the override functions in this class.

Further, everything in this class except the constructor that is currently protected seems like it should be private instead.

[Joanmarie Diggs]

Created attachment 273979 [details]
Patch

[Joanmarie Diggs]

@Darin: Changes made. Thanks for the review!

@Chris: Accessibility sanity check? :)

[chris fleizach]

(In reply to comment #5)
> @Darin: Changes made. Thanks for the review!
> 
> @Chris: Accessibility sanity check? :)

LGTM

[WebKit Commit Bot]

Comment on attachment 273979 [details]
Patch

Clearing flags on attachment: 273979

Committed r198137: <http://trac.webkit.org/changeset/198137>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.