Bug 155354 - Enable GSS-Negotiate support in libsoup
Summary: Enable GSS-Negotiate support in libsoup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-11 02:07 PST by Tomas Popela
Modified: 2016-03-14 08:13 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2016-03-11 02:12 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-yosemite (811.59 KB, application/zip)
2016-03-11 05:16 PST, Build Bot 		no flags Details
Patch (1.65 KB, patch)
2016-03-14 07:19 PDT, Tomas Popela 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2016-03-11 02:07:02 PST 
Once enabled the libsoup based ports will be able to automatically authenticate with the GSS-Negotiate if server supports it.

For the technical background, please see https://bugzilla.gnome.org/show_bug.cgi?id=587145.
Comment 1 Tomas Popela 2016-03-11 02:12:47 PST 
Created attachment 273713 [details]
Patch

Avoiding commit queue as it will be better to land this manually, once the Dan will commit the libsoup change.
Comment 2 Build Bot 2016-03-11 05:16:51 PST 
Comment on attachment 273713 [details]
Patch

Attachment 273713 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/960357

New failing tests:
js/function-apply.html
Comment 3 Build Bot 2016-03-11 05:16:54 PST 
Created attachment 273721 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Michael Catanzaro 2016-03-11 08:01:24 PST 
Comment on attachment 273713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273713&action=review

I didn't realize this way landing for 3.20. Yippee. :)

Please leave a comment once this lands in libsoup; we'll want to wait for that before committing.

> Source/WebCore/ChangeLog:8
> +        Enable the SOUP_TYPE_AUTH_NEGOTIATE feature inf libsoup was compiled

if

> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:114
> +    if (soup_auth_negotiate_supported) {

Nit: not sure if this makes any difference, but maybe would be better beneath the call to setupLogger?
Comment 5 Tomas Popela 2016-03-14 04:36:02 PDT 
(In reply to comment #4)
> > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:114
> > +    if (soup_auth_negotiate_supported) {
> 
> Nit: not sure if this makes any difference, but maybe would be better
> beneath the call to setupLogger?

I don't think it makes any difference, I will leave it as it is.
Comment 6 Tomas Popela 2016-03-14 07:19:10 PDT 
Created attachment 273970 [details]
Patch

Updated patch to reflect latest changes and typo in the changelog. The libsoup part is already done with https://git.gnome.org/browse/libsoup/commit/?id=6a8826f0d25459c943719b88f22619f22b81c547 .
Comment 7 WebKit Commit Bot 2016-03-14 08:13:36 PDT 
Comment on attachment 273970 [details]
Patch

Clearing flags on attachment: 273970

Committed r198127: <http://trac.webkit.org/changeset/198127>
Comment 8 WebKit Commit Bot 2016-03-14 08:13:40 PDT 
All reviewed patches have been landed.  Closing bug.