Bug 155343 – [iOS] Allow clients to specify text suggestions to be used for a form input session

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chelsea Pugh]

Allow clients to specify text suggestions to be used for a form input session. Patch forthcoming.

[Chelsea Pugh]

Created attachment 273685 [details]
Patch to resolve [iOS] Allow clients to specify text suggestions to be used for a form input session

Comment on attachment 273685 [details]
Patch to resolve [iOS] Allow clients to specify text suggestions to be used for a form input session

View in context: https://bugs.webkit.org/attachment.cgi?id=273685&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:313
> +    id <UITextInputSuggestionDelegate> suggestionDelegate = (id <UITextInputSuggestionDelegate>)_contentView.inputDelegate;

Should we assert that this was a valid cast?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:314
> +    _suggestions = suggestions;

You should adhere to the API contract and copy the array here.

[Chelsea Pugh]

Created attachment 273765 [details]
patch version 2

[WebKit Commit Bot]

Attachment 273765 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:324:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 273765 [details]
patch version 2

View in context: https://bugs.webkit.org/attachment.cgi?id=273765&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKInputDelegate.h:48
>  - (BOOL)_webView:(WKWebView *)webView hasSuggestionsForCurrentStringInInputSession:(id <_WKFormInputSession>)inputSession;
>  - (NSArray *)_webView:(WKWebView *)webView suggestionsForString:(NSString *)string inInputSession:(id <_WKFormInputSession>)inputSession;

Shouldn’t be part of this bug, but I think we can get rid of this old suggestions API, since we never ended up invoking these methods.

Committed <http://trac.webkit.org/r198046>.