RESOLVED FIXED 155331
Expose additional WKDataDetectorTypes 
https://bugs.webkit.org/show_bug.cgi?id=155331
Summary Expose additional WKDataDetectorTypes
Enrica Casucci
Reported 2016-03-10 15:22:02 PST
Adding support for flight, tracking numbers and spotlight suggestions. rdar://problem/24175813
Attachments
Patch (10.98 KB, patch)
2016-03-10 15:27 PST, Enrica Casucci 		thorton: review-
DetailsFormatted DiffDiff
Patch2 (9.97 KB, patch)
2016-03-10 16:47 PST, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2016-03-10 15:27:00 PST
Created attachment 273635 [details] Patch
WebKit Commit Bot
Comment 2 2016-03-10 15:28:32 PST
Attachment 273635 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2016-03-10 16:07:46 PST
Comment on attachment 273635 [details] Patch I think we need some naming changes here. Will discuss offline.
Enrica Casucci
Comment 4 2016-03-10 16:47:30 PST
Created attachment 273653 [details] Patch2
WebKit Commit Bot
Comment 5 2016-03-10 16:50:17 PST
Attachment 273653 [details] did not pass style-queue: ERROR: Source/WebCore/editing/cocoa/DataDetection.mm:47: *SoftLink.h header should be included after all other headers. [build/include_order] [4] ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Enrica Casucci
Comment 6 2016-03-10 17:06:55 PST
Committed revision 197976.
David Kilzer (:ddkilzer)
Comment 8 2016-03-10 21:01:51 PST
(In reply to comment #7) > This change broke Mac and iOS builds > > <https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Release%20%28Build%29/builds/4426> > <https://build.webkit.org/builders/ > Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/4356> Committed r197977: <http://trac.webkit.org/r197977> Additional fix for internal iOS 9.x SDK builds: Committed r197992: <http://trac.webkit.org/r197992>
Tim Horton
Comment 9 2016-03-10 21:09:32 PST
(In reply to comment #8) > (In reply to comment #7) > > This change broke Mac and iOS builds > > > > <https://build.webkit.org/builders/ > > Apple%20El%20Capitan%20Release%20%28Build%29/builds/4426> > > <https://build.webkit.org/builders/ > > Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/4356> > > Committed r197977: <http://trac.webkit.org/r197977> > > Additional fix for internal iOS 9.x SDK builds: > > Committed r197992: <http://trac.webkit.org/r197992> I don't think that will fix anything by itself; I landed 197993 on top of it which should actually fix.
David Kilzer (:ddkilzer)
Comment 10 2016-03-10 21:45:02 PST
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > This change broke Mac and iOS builds > > > > > > <https://build.webkit.org/builders/ > > > Apple%20El%20Capitan%20Release%20%28Build%29/builds/4426> > > > <https://build.webkit.org/builders/ > > > Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/4356> > > > > Committed r197977: <http://trac.webkit.org/r197977> > > > > Additional fix for internal iOS 9.x SDK builds: > > > > Committed r197992: <http://trac.webkit.org/r197992> > > I don't think that will fix anything by itself; I landed 197993 on top of it > which should actually fix. Yes, it wasn't a complete fix in hindsight; only addressed the missing DDOptionalSource.h header error. Thanks Tim!
Note You need to log in before you can comment on or make changes to this bug.