Bug 155318 - Web Inspector: TreeOutlineDataGridSynchronizer should be optional in TimelineDataGrid
Summary: Web Inspector: TreeOutlineDataGridSynchronizer should be optional in Timeline...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 153036
  Show dependency tree / graph
 
Reported: 2016-03-10 12:44 PST by Matt Baker
Modified: 2016-03-10 14:58 PST (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (9.89 KB, patch)
2016-03-10 12:54 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-03-10 12:44:49 PST 
* SUMMARY
TreeOutlineDataGridSynchronizer should be optional in TimelineDataGrid. TimelineViews no longer use tree outlines, but the synchronizer still needs to be supported since the Network tab uses a TimelineDataGrid.

For clients of TimelineDataGrid, the only change is to TimelineDataGrid.addRowInSortOrder:

TimelineDataGrid.prototype.addRowInSortOrder(treeElement, dataGridNode, parentTreeElementOrDataGridNode)

- treeElement: optional, TimelineView's will pass null.
- parentTreeElementOrDataGridNode: overloaded parameter. TimelineViews will pass a DataGridNode instead of a tree element.
Comment 1 Radar WebKit Bug Importer 2016-03-10 12:45:05 PST 
<rdar://problem/25091949>
Comment 2 Matt Baker 2016-03-10 12:54:22 PST 
Created attachment 273603 [details]
[Patch] Proposed Fix
Comment 3 WebKit Commit Bot 2016-03-10 14:58:18 PST 
Comment on attachment 273603 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 273603

Committed r197958: <http://trac.webkit.org/changeset/197958>
Comment 4 WebKit Commit Bot 2016-03-10 14:58:22 PST 
All reviewed patches have been landed.  Closing bug.