Bug 155304 – defaultActions in UIDelegate method previewingViewControllerForElement:defaultActions: need to be useable by a client

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

defaultActions in UIDelegate method previewingViewControllerForElement:defaultActions: need to be use-able by a client

<rdar://problem/24269296>

[Beth Dakin]

Created attachment 273586 [details]
Patch

[WebKit Commit Bot]

Attachment 273586 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3901:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Created attachment 273591 [details]
Patch

[WebKit Commit Bot]

Attachment 273591 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3901:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Created attachment 273640 [details]
Patch

[Beth Dakin]

Created attachment 273646 [details]
Patch

[WebKit Commit Bot]

Attachment 273646 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKPreviewAction.h:34:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3902:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 273646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273646&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKElementAction.h:64
> +- (NSString *)previewIdentifier;

Why is this here?

> Source/WebKit2/UIProcess/API/Cocoa/_WKPreviewAction.h:34
> +@property(nonatomic, copy, readonly) NSString *identifier;

Newline before @proeprty

> Source/WebKit2/UIProcess/API/Cocoa/_WKPreviewAction.h:35
> +@end

Newline before @end

> Source/WebKit2/UIProcess/API/Cocoa/_WKPreviewAction.h:38
> +

No newline!

[Beth Dakin]

I addressed all of the comments: http://trac.webkit.org/changeset/197973

Thanks Anders!!

Why are we exposing both the class and the protocol in a private header? Can the class remain an internal implementation detail?

[Beth Dakin]

(In reply to comment #10)
> Why are we exposing both the class and the protocol in a private header? Can
> the class remain an internal implementation detail?

Patch posted: https://bugs.webkit.org/show_bug.cgi?id=155370

Good catch, Dan!