Bug 155300 – Add shouldNotBe to standalone test harness

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy VanWagoner]

Add shouldNotBe to standalone test harness

[Andy VanWagoner]

Created attachment 273576 [details]
Patch

[Saam Barati]

Comment on attachment 273576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273576&action=review

> LayoutTests/resources/standalone-pre.js:324
>  function dfgCompiled(argument)
>  {
>      var numberOfCompiles = "compiles" in argument ? argument.compiles : 1;
> -    
> +
>      if (!("f" in argument))
>          throw new Error("dfgCompiled called with invalid argument.");
> -    
> +
>      if (argument.f instanceof Array) {
>          for (var i = 0; i < argument.f.length; ++i) {

Please revert all whitespace changes.

[Andy VanWagoner]

Created attachment 273589 [details]
Patch

[Andy VanWagoner]

(In reply to comment #2)
> Comment on attachment 273576 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273576&action=review
> 
> > LayoutTests/resources/standalone-pre.js:324
> >  function dfgCompiled(argument)
> >  {
> >      var numberOfCompiles = "compiles" in argument ? argument.compiles : 1;
> > -    
> > +
> >      if (!("f" in argument))
> >          throw new Error("dfgCompiled called with invalid argument.");
> > -    
> > +
> >      if (argument.f instanceof Array) {
> >          for (var i = 0; i < argument.f.length; ++i) {
> 
> Please revert all whitespace changes.

done

[Ryan Haddad]

Comment on attachment 273589 [details]
Patch

Marking cq+ to fix the tests.

[WebKit Commit Bot]

Comment on attachment 273589 [details]
Patch

Clearing flags on attachment: 273589

Committed r197969: <http://trac.webkit.org/changeset/197969>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.