Bug 155300 - Add shouldNotBe to standalone test harness
Summary: Add shouldNotBe to standalone test harness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy VanWagoner
URL:
Keywords:
Depends on:
Blocks: 153679
  Show dependency tree / graph
 
Reported: 2016-03-10 09:35 PST by Andy VanWagoner
Modified: 2016-03-10 16:42 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2016-03-10 09:38 PST, Andy VanWagoner 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2016-03-10 11:40 PST, Andy VanWagoner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy VanWagoner 2016-03-10 09:35:09 PST 
Add shouldNotBe to standalone test harness
Comment 1 Andy VanWagoner 2016-03-10 09:38:09 PST 
Created attachment 273576 [details]
Patch
Comment 2 Saam Barati 2016-03-10 11:35:03 PST 
Comment on attachment 273576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273576&action=review

> LayoutTests/resources/standalone-pre.js:324
>  function dfgCompiled(argument)
>  {
>      var numberOfCompiles = "compiles" in argument ? argument.compiles : 1;
> -    
> +
>      if (!("f" in argument))
>          throw new Error("dfgCompiled called with invalid argument.");
> -    
> +
>      if (argument.f instanceof Array) {
>          for (var i = 0; i < argument.f.length; ++i) {

Please revert all whitespace changes.
Comment 3 Andy VanWagoner 2016-03-10 11:40:12 PST 
Created attachment 273589 [details]
Patch
Comment 4 Andy VanWagoner 2016-03-10 11:40:52 PST 
(In reply to comment #2)
> Comment on attachment 273576 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273576&action=review
> 
> > LayoutTests/resources/standalone-pre.js:324
> >  function dfgCompiled(argument)
> >  {
> >      var numberOfCompiles = "compiles" in argument ? argument.compiles : 1;
> > -    
> > +
> >      if (!("f" in argument))
> >          throw new Error("dfgCompiled called with invalid argument.");
> > -    
> > +
> >      if (argument.f instanceof Array) {
> >          for (var i = 0; i < argument.f.length; ++i) {
> 
> Please revert all whitespace changes.

done
Comment 5 Ryan Haddad 2016-03-10 15:53:07 PST 
Comment on attachment 273589 [details]
Patch

Marking cq+ to fix the tests.
Comment 6 WebKit Commit Bot 2016-03-10 16:42:06 PST 
Comment on attachment 273589 [details]
Patch

Clearing flags on attachment: 273589

Committed r197969: <http://trac.webkit.org/changeset/197969>
Comment 7 WebKit Commit Bot 2016-03-10 16:42:09 PST 
All reviewed patches have been landed.  Closing bug.