Bug 155298 – Separate render tree updating from style resolve

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

We currently update the render tree as we resolve style. If we need to create new renderers we enter a different code path that replicates much of the style resolve code. Making style resolve and render tree updating two separate operations will clean up the code and enable future improvements.

[Antti Koivisto]

Created attachment 273570 [details]
wip

[Antti Koivisto]

Created attachment 273571 [details]
wip

[Build Bot]

Comment on attachment 273571 [details]
wip

Attachment 273571 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/954621

New failing tests:
editing/inserting/insert-at-end-02.html
media/video-controls-captions-trackmenu-localized.html
editing/inserting/editing-empty-divs.html
media/controls/elementOrder.html
editing/style/typing-style-003.html
media/video-controls-audiotracks-trackmenu.html
accessibility/accessibility-node-reparent.html
editing/mac/spelling/autocorrection-simple.html
imported/blink/svg/css/svg-length-rem-type.svg
media/video-trackmenu-selection.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
mathml/presentation/menclose-notation-attribute-change-value.html
imported/blink/fast/css-generated-content/pseudo-animation-display.html
media/media-controls-drag-timeline-set-controls-property.html
animations/cross-fade-list-style-image.html
editing/selection/4983858.html
editing/mac/spelling/autocorrection-removing-underline.html
media/video-controls-captions-trackmenu-sorted.html
editing/mac/spelling/autocorrection-removing-underline-after-paste.html
imported/blink/fast/pagination/first-letter-inherit-all-crash.html
editing/inserting/editable-html-element.html
editing/pasteboard/4989774.html
media/controls/track-menu.html
editing/style/remove-underline-from-stylesheet.html
media/controls/statusDisplay.html
editing/mac/spelling/autocorrection-contraction.html
media/track/track-manual-mode.html
css3/blending/repaint/blend-mode-isolate-stacking-context.html

[Build Bot]

Created attachment 273574 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 273825 [details]
wip

[Antti Koivisto]

Created attachment 273829 [details]
wip

[WebKit Commit Bot]

Attachment 273829 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleSharingResolver.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 273829 [details]
wip

Attachment 273829 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/965538

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 273832 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 273835 [details]
wip

[WebKit Commit Bot]

Attachment 273835 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleSharingResolver.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 273835 [details]
wip

Attachment 273835 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/968265

New failing tests:
mathml/presentation/menclose-notation-attribute-change-value.html
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
media/controls-drag-timebar.html
media/controls/elementOrder.html
media/controls/track-menu.html
editing/mac/spelling/autocorrection-removing-underline.html
editing/mac/spelling/autocorrection-contraction.html
media/track/track-manual-mode.html
media/video-controls-captions-trackmenu-sorted.html
editing/mac/spelling/autocorrection-removing-underline-after-paste.html
editing/mac/spelling/autocorrection-simple.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273858 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 273875 [details]
wip

[Antti Koivisto]

Created attachment 273876 [details]
wip

[Antti Koivisto]

Created attachment 273879 [details]
wip

[Antti Koivisto]

Created attachment 273882 [details]
wip

[Build Bot]

Comment on attachment 273882 [details]
wip

Attachment 273882 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/970504

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
mathml/presentation/menclose-notation-attribute-change-value.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/track/track-manual-mode.html
media/video-controls-captions-trackmenu-sorted.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273884 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273882 [details]
wip

Attachment 273882 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/970502

New failing tests:
editing/style/typing-style-003.html
fast/regions/position-writing-modes-in-variable-width-regions.html
mathml/presentation/menclose-notation-attribute-change-value.html

[Build Bot]

Created attachment 273885 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273882 [details]
wip

Attachment 273882 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/970516

New failing tests:
mathml/presentation/menclose-notation-attribute-change-value.html
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
media/controls-drag-timebar.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/media-controls-drag-timeline-set-controls-property.html
media/controls/statusDisplay.html
media/track/track-manual-mode.html
media/video-controls-captions-trackmenu-sorted.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273886 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273882 [details]
wip

Attachment 273882 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/970490

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
mathml/presentation/menclose-notation-attribute-change-value.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/media-controls-drag-timeline-set-controls-property.html
media/track/track-manual-mode.html
media/video-controls-captions-trackmenu-sorted.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273887 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 273931 [details]
wip

[Build Bot]

Comment on attachment 273931 [details]
wip

Attachment 273931 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/975871

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/track/track-manual-mode.html
media/video-controls-captions-trackmenu-sorted.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273937 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273931 [details]
wip

Attachment 273931 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/975921

New failing tests:
editing/style/typing-style-003.html
fast/regions/position-writing-modes-in-variable-width-regions.html

[Build Bot]

Created attachment 273938 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273931 [details]
wip

Attachment 273931 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/975925

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
media/controls-drag-timebar.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/media-controls-drag-timeline-set-controls-property.html
media/controls/statusDisplay.html
media/track/track-manual-mode.html
media/video-controls-captions-trackmenu-sorted.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273939 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273931 [details]
wip

Attachment 273931 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/975972

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/controls/track-menu.html
media/track/track-text-track-destructor-crash.html
media/track/track-manual-mode.html

[Build Bot]

Created attachment 273942 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 273949 [details]
for bots

[Antti Koivisto]

Created attachment 273955 [details]
for bots

[Build Bot]

Comment on attachment 273955 [details]
for bots

Attachment 273955 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/976659

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/controls/statusDisplay.html
media/track/track-manual-mode.html
media/video-controls-captions-trackmenu-sorted.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273959 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273955 [details]
for bots

Attachment 273955 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/976656

New failing tests:
editing/style/typing-style-003.html
fast/regions/position-writing-modes-in-variable-width-regions.html

[Build Bot]

Created attachment 273960 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273955 [details]
for bots

Attachment 273955 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/976664

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
media/video-controls-captions-trackmenu-localized.html
media/controls-drag-timebar.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/media-controls-drag-timeline-set-controls-property.html
media/controls/statusDisplay.html
media/video-controls-captions-trackmenu-sorted.html
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 273961 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273955 [details]
for bots

Attachment 273955 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/976743

New failing tests:
media/video-controls-audiotracks-trackmenu.html
media/controls/track-menu.html
media/track/track-text-track-destructor-crash.html
media/track/track-manual-mode.html

[Build Bot]

Created attachment 273963 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 273968 [details]
for bots

[Build Bot]

Comment on attachment 273968 [details]
for bots

Attachment 273968 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/977369

New failing tests:
media/controls/elementOrder.html
media/controls/track-menu.html

[Build Bot]

Created attachment 273976 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273968 [details]
for bots

Attachment 273968 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/977368

New failing tests:
media/controls/statusDisplay.html
media/controls/elementOrder.html
media/controls/track-menu.html
media/media-controls-drag-timeline-set-controls-property.html
media/controls-drag-timebar.html

[Build Bot]

Created attachment 273977 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273968 [details]
for bots

Attachment 273968 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/977367

New failing tests:
editing/style/typing-style-003.html
fast/regions/position-writing-modes-in-variable-width-regions.html

[Build Bot]

Created attachment 273978 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273968 [details]
for bots

Attachment 273968 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/977416

New failing tests:
media/controls/track-menu.html
media/track/track-text-track-destructor-crash.html

[Build Bot]

Created attachment 273982 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 274409 [details]
for bots

[Build Bot]

Comment on attachment 274409 [details]
for bots

Attachment 274409 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/999452

New failing tests:
media/controls/elementOrder.html

[Build Bot]

Created attachment 274410 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274409 [details]
for bots

Attachment 274409 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/999458

New failing tests:
media/controls/statusDisplay.html
media/controls/elementOrder.html
media/media-controls-drag-timeline-set-controls-property.html
media/controls-drag-timebar.html

[Build Bot]

Created attachment 274411 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274409 [details]
for bots

Attachment 274409 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/999455

New failing tests:
editing/style/typing-style-003.html
fast/regions/position-writing-modes-in-variable-width-regions.html

[Build Bot]

Created attachment 274412 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274409 [details]
for bots

Attachment 274409 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/999469

New failing tests:
media/controls/elementOrder.html
media/controls-drag-timebar.html

[Build Bot]

Created attachment 274413 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 274581 [details]
patch

[Build Bot]

Comment on attachment 274581 [details]
patch

Attachment 274581 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1015701

New failing tests:
media/controls/elementOrder.html
media/media-controls-drag-timeline-set-controls-property.html

[Build Bot]

Created attachment 274584 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274581 [details]
patch

Attachment 274581 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1015704

New failing tests:
media/controls/statusDisplay.html
media/controls/elementOrder.html
media/media-controls-drag-timeline-set-controls-property.html
media/controls-drag-timebar.html

[Build Bot]

Created attachment 274586 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274581 [details]
patch

Attachment 274581 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1015702

New failing tests:
editing/style/typing-style-003.html
fast/regions/position-writing-modes-in-variable-width-regions.html

[Build Bot]

Created attachment 274588 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274581 [details]
patch

Attachment 274581 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1015709

New failing tests:
media/controls/elementOrder.html
media/media-controls-drag-timeline-set-controls-property.html

[Build Bot]

Created attachment 274595 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Ahha. webkitcurrentplaybacktargetiswirelesschangedEvent hides these media control test failures locally. Commenting it out makes them repro.

[Antti Koivisto]

Created attachment 274731 [details]
for bots

[Build Bot]

Comment on attachment 274731 [details]
for bots

Attachment 274731 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1024809

New failing tests:
media/controls/track-menu.html

[Build Bot]

Created attachment 274734 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274731 [details]
for bots

Attachment 274731 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1024810

New failing tests:
media/controls/track-menu.html

[Build Bot]

Created attachment 274735 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274731 [details]
for bots

Attachment 274731 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1024808

New failing tests:
editing/style/typing-style-003.html

[Build Bot]

Created attachment 274736 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 274731 [details]
for bots

Attachment 274731 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1024816

New failing tests:
media/controls/track-menu.html

[Antti Koivisto]

Created attachment 274737 [details]
for bots

[Build Bot]

Created attachment 274738 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 274896 [details]
for bots

[Antti Koivisto]

Created attachment 274983 [details]
patch

[Andreas Kling]

Comment on attachment 274983 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274983&action=review

r=me

> Source/WebCore/style/RenderTreeUpdater.cpp:117
> +    // FIXME: SVG <use> element may cause tree mutations during style recalc.

This would be nice to get fixed, then.

> Source/WebCore/style/StyleUpdate.cpp:48
> +    auto it = m_elements.find(&element);
> +    if (it == m_elements.end())
> +        return nullptr;
> +    return &it->value;

I suppose this could just be "m_elements.get(&element);"

[Antti Koivisto]

https://trac.webkit.org/r198828

[WebKit Commit Bot]

Re-opened since this is blocked by bug 156030

[Antti Koivisto]

Created attachment 275310 [details]
patch

[Build Bot]

Comment on attachment 275310 [details]
patch

Attachment 275310 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1076913

New failing tests:
svg/W3C-SVG-1.1-SE/types-dom-07-f.svg
svg/W3C-SVG-1.1/animate-elem-31-t.svg
plugins/focus.html
svg/W3C-SVG-1.1-SE/types-dom-02-f.svg
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/foreignObject/fO-parent-display-none.svg
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
svg/custom/painting-marker-07-f-inherit.svg
svg/as-image/img-zoom-svg-stylesheet.html
svg/W3C-SVG-1.1/pservers-grad-19-b.svg
svg/carto.net/tabgroup.svg
svg/custom/use-recalcStyle-crash.svg
svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
svg/foreignObject/fO-parent-of-parent-display-none.svg
svg/W3C-SVG-1.1/struct-group-03-t.svg
fast/dom/beforeload/remove-flash-in-beforeload-listener.html

[Build Bot]

Created attachment 275317 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275310 [details]
patch

Attachment 275310 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1076918

New failing tests:
svg/W3C-SVG-1.1-SE/types-dom-07-f.svg
svg/W3C-SVG-1.1/animate-elem-31-t.svg
plugins/focus.html
svg/W3C-SVG-1.1-SE/types-dom-02-f.svg
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/foreignObject/fO-parent-display-none.svg
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
svg/custom/painting-marker-07-f-inherit.svg
svg/as-image/img-zoom-svg-stylesheet.html
svg/W3C-SVG-1.1/pservers-grad-19-b.svg
svg/carto.net/tabgroup.svg
svg/custom/use-recalcStyle-crash.svg
svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
svg/foreignObject/fO-parent-of-parent-display-none.svg
svg/W3C-SVG-1.1/struct-group-03-t.svg
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg

[Build Bot]

Created attachment 275318 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275310 [details]
patch

Attachment 275310 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1076923

New failing tests:
svg/foreignObject/fO-parent-display-none.svg
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
svg/custom/painting-marker-07-f-inherit.svg
svg/as-image/img-zoom-svg-stylesheet.html
svg/custom/use-recalcStyle-crash.svg
svg/foreignObject/fO-parent-of-parent-display-none.svg
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg

[Build Bot]

Created attachment 275320 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275310 [details]
patch

Attachment 275310 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1076963

New failing tests:
svg/W3C-SVG-1.1-SE/types-dom-07-f.svg
svg/W3C-SVG-1.1/animate-elem-31-t.svg
plugins/focus.html
svg/W3C-SVG-1.1/pservers-grad-19-b.svg
svg/W3C-SVG-1.1-SE/types-dom-02-f.svg
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/foreignObject/fO-parent-display-none.svg
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
svg/custom/painting-marker-07-f-inherit.svg
svg/as-image/img-zoom-svg-stylesheet.html
fast/dom/beforeload/remove-flash-in-beforeload-listener.html
svg/W3C-SVG-1.1/struct-group-03-t.svg
svg/carto.net/tabgroup.svg
svg/custom/use-recalcStyle-crash.svg
svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
svg/foreignObject/fO-parent-of-parent-display-none.svg
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg

[Build Bot]

Created attachment 275323 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 275376 [details]
patch

[Antti Koivisto]

Created attachment 275381 [details]
patch

[Antti Koivisto]

The PLT regression was due to unnecessarily computing style for display:none subtrees. Relanded in https://trac.webkit.org/r198943

[Antti Koivisto]

rdar://problem/25491019