Bug 155296 - [GTK] Fix rendering of slider input elements
Summary: [GTK] Fix rendering of slider input elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-03-10 06:13 PST by Carlos Garcia Campos
Modified: 2016-03-10 23:04 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.24 KB, patch)
2016-03-10 06:17 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-03-10 06:13:00 PST
Use the new gadgets for newer GTK+ and improve a bit the rendering for previous versions to better match GTK+.
Comment 1 Carlos Garcia Campos 2016-03-10 06:17:23 PST
Created attachment 273564 [details]
Patch
Comment 2 Michael Catanzaro 2016-03-10 06:54:12 PST
Comment on attachment 273564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273564&action=review

Sigh

> Source/WebCore/ChangeLog:13
> +        ScaleHighlight parts that are onlu used with GTK+ 3.19.

only

> Source/WebCore/rendering/RenderThemeGtk.cpp:1114
> +    // the slider track separetly and the track rectasngle we receive here can't be used to apply the GTK+ CSS sizes

separately, rectangle
Comment 3 Carlos Garcia Campos 2016-03-10 23:04:56 PST
Committed r197998: <http://trac.webkit.org/changeset/197998>